incubator-blur-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron McCurry (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BLUR-289) Table Properties are not being persisted to zookeeper
Date Sat, 26 Oct 2013 14:15:31 GMT

    [ https://issues.apache.org/jira/browse/BLUR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806107#comment-13806107
] 

Aaron McCurry commented on BLUR-289:
------------------------------------

What think about changing the way we store the whole thing?  I was going to put this off until
0.3, but since I would consider all the things we store in ZooKeeper internal and private
I think it's ok to change things a bit.

What if we remove everything in all the sub nodes except for the enabled child.  And just
use the thrift + json protocol to store the entire TableDescriptor object in the table node?
 That way in the future we don't have to worry about adding new fields.  The only catch is
that we will need to convert existing Tables (0.2.0) to this format.  So the existing reading
code needs to stay in place to allow us to convert it.

What do you think?

If you need help with the thrift code let me know and I can point you to some examples.

Also the reason to keep the enabled path is because of the watchers in zookeeper are keyed
off that path and it will be more changes to remove it now.  In 0.3.0 we can go ahead and
remove that child node, unless you feel up to that as well.  We can talk about that one.

What do you think?

Aaron

> Table Properties are not being persisted to zookeeper
> -----------------------------------------------------
>
>                 Key: BLUR-289
>                 URL: https://issues.apache.org/jira/browse/BLUR-289
>             Project: Apache Blur
>          Issue Type: Bug
>          Components: Blur
>    Affects Versions: 0.3.0, 0.2.1
>            Reporter: Rahul Challapalli
>            Priority: Blocker
>             Fix For: 0.2.1
>
>         Attachments: persist_tableproperties.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message