incubator-blur-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From g...@apache.org
Subject git commit: BLUR:110 changed test names and added more tests.
Date Tue, 04 Jun 2013 13:52:08 GMT
Updated Branches:
  refs/heads/0.1.5 20e538992 -> a3e4f3c13


BLUR:110 changed test names and added more tests.


Project: http://git-wip-us.apache.org/repos/asf/incubator-blur/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-blur/commit/a3e4f3c1
Tree: http://git-wip-us.apache.org/repos/asf/incubator-blur/tree/a3e4f3c1
Diff: http://git-wip-us.apache.org/repos/asf/incubator-blur/diff/a3e4f3c1

Branch: refs/heads/0.1.5
Commit: a3e4f3c13aa4b82b36e3b920dc1ccf4952976779
Parents: 20e5389
Author: Gagan <gagandeepjuneja@gmail.com>
Authored: Tue Jun 4 19:21:39 2013 +0530
Committer: Gagan <gagandeepjuneja@gmail.com>
Committed: Tue Jun 4 19:21:39 2013 +0530

----------------------------------------------------------------------
 .../manager/writer/TransactionRecorderTest.java    |   23 ++++++++++++--
 1 files changed, 19 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-blur/blob/a3e4f3c1/src/blur-core/src/test/java/org/apache/blur/manager/writer/TransactionRecorderTest.java
----------------------------------------------------------------------
diff --git a/src/blur-core/src/test/java/org/apache/blur/manager/writer/TransactionRecorderTest.java
b/src/blur-core/src/test/java/org/apache/blur/manager/writer/TransactionRecorderTest.java
index bda6e8e..8ab85a4 100644
--- a/src/blur-core/src/test/java/org/apache/blur/manager/writer/TransactionRecorderTest.java
+++ b/src/blur-core/src/test/java/org/apache/blur/manager/writer/TransactionRecorderTest.java
@@ -136,18 +136,33 @@ public class TransactionRecorderTest {
   }
   
   @Test(expected=IllegalArgumentException.class)
-  public void testConvertShouldFail(){
-    String rowId = "RowId_123.1";
+  public void testConvertWithBadFamilyNameShouldFail(){
+    String rowId = "RowId_123-1";
     Record record = new Record();
     record.setRecordId("RecordId_123-1");
-    record.setFamily("Family_123-1");
+    record.setFamily("Family_123.1");
     
     Column column = new Column();
     column.setName("columnName_123-1");
     record.setColumns(Arrays.asList(column));
     
     TransactionRecorder.convert(rowId, record, new StringBuilder(), new BlurAnalyzer());
-    assert(true);
+    fail();
+  }
+  
+  @Test(expected=IllegalArgumentException.class)
+  public void testConvertWithBadColumnNameShouldFail(){
+    String rowId = "RowId_123-1";
+    Record record = new Record();
+    record.setRecordId("RecordId_123-1");
+    record.setFamily("Family_123-1");
+    
+    Column column = new Column();
+    column.setName("columnName_123.1");
+    record.setColumns(Arrays.asList(column));
+    
+    TransactionRecorder.convert(rowId, record, new StringBuilder(), new BlurAnalyzer());
+    fail();
   }
 
   private Row genRow() {


Mime
View raw message