incubator-bloodhound-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Olemis Lang <ole...@gmail.com>
Subject Re: svn commit: r1455438 - in /incubator/bloodhound/branches/bep_0003_multiproduct: ./ bloodhound_theme/bhtheme/ bloodhound_theme/bhtheme/templates/ trac/ trac/trac/ trac/trac/tests/ trac/trac/ticket/ trac/trac/ticket/tests/ trac/trac/wiki/ trac/trac/wiki/...
Date Wed, 13 Mar 2013 05:42:27 GMT
On 3/12/13, jure@apache.org <jure@apache.org> wrote:
>
[...]
> @@ -235,8 +235,7 @@ class Attachment(object):
>
>          self.env.log.info("Attachment removed: %s" % self.title)
>
> -        for listener in AttachmentModule(self.env).change_listeners:
> -            listener.attachment_deleted(self)
> +        ResourceSystem(self.env).resource_deleted(self)
>
[...]
>
> -        for listener in AttachmentModule(self.env).change_listeners:
> -            if hasattr(listener, 'attachment_reparented'):
> -                listener.attachment_reparented(self, old_realm, old_id)
> +        old_values = dict(parent_realm=old_realm, parent_id=old_id)
> +        ResourceSystem(self.env).resource_changed(self,
> old_values=old_values)
>
[...]
>
> -        for listener in AttachmentModule(self.env).change_listeners:
> -            listener.attachment_added(self)
> +        ResourceSystem(self.env).resource_created(self)
>
[...]
>
> +class ResourceToAttachmentChangeListenerAdapter(Component):
> +    """
> +    The class provides backward compatibility for components implementing
> +    IAttachmentChangeListener interface.
> +    """

-1
Move these into AttachmentModule itself , so that legacy notification
will always be enabled if the module is enabled .

PS: The same applies to all other backwards compatibility interface adapters .

-- 
Regards,

Olemis.

Mime
View raw message