incubator-bloodhound-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Olemis Lang <ole...@gmail.com>
Subject Re: svn commit: r1455576 - in /incubator/bloodhound/branches/bep_0003_multiproduct/bloodhound_multiproduct/multiproduct: api.py hooks.py web_ui.py
Date Wed, 13 Mar 2013 07:58:10 GMT
On 3/13/13, Jure Zitnik <jure@digiverse.si> wrote:
> On 3/13/13 5:18 AM, Branko ─îibej wrote:
>> On 13.03.2013 05:08, Olemis Lang wrote:
>>> On 3/12/13, jure@apache.org <jure@apache.org> wrote:
>>>> Author: jure
>>>> Date: Tue Mar 12 15:15:22 2013
>>>> New Revision: 1455576
>>>>
>>>> URL: http://svn.apache.org/r1455576
>>>> Log:
>>>> Renamed default product to '@',
>>> @jure: why ?
>> Because it's a token that is forbidden as a product tag and therefore
>> cannot conflict with existing product names.

I'll ask the negation of the negation .

Why is it that we'll have to apply this change instead of sticking to
'' as global prefix?

>
> Brane, I double checked and currently there's no prefix checking on
> product creation, though we should add one to prevent someone from
> adding product with funky prefixes, including the reserved '@' ... I
> think '^[a-zA-Z0-9_]+$' would suffice for now.
>

-0 ... I'd suggest (?:(?!\d)\w+) ... which is already available in
multiproduct.util.IDENTIFIER after recent patches .

-- 
Regards,

Olemis.

Mime
View raw message