incubator-bloodhound-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matevž Bradač <mate...@gmail.com>
Subject Re: [Apache Bloodhound] #420: Improved styling for `inline code`
Date Sat, 02 Mar 2013 21:48:30 GMT

On 2. Mar, 2013, at 9:48, Olemis Lang wrote:

> On 3/1/13, Ryan Ollos <ryan.ollos@wandisco.com> wrote:
>> On Fri, Mar 1, 2013 at 2:28 PM, Matevž Bradač <matevzb@gmail.com> wrote:
>>> On 1. Mar, 2013, at 21:47, Olemis Lang wrote:
>>>> On 3/1/13, Gary Martin <gary.martin@wandisco.com> wrote:
>>>> [...]
>>>>> 
>>>>> There are a lot of potential ways of doing this. I am not keen on
>>>>> copying the CSS across if we want to be sticking to whatever bootstrap
>>>>> provides. That leaves swapping tags, which itself can probably be done
>>>>> in three or more ways, or copying the styles on the client side with
>>>>> js.
>>>>> 
>>>> 
>>>> I was initially thinking of introducing (overriding) these in
>>>> bloodhound.css rather than modifying bootstrap.css
>>> 
>>> I think that's what Gary was referring to as well.
> 
> yeah ... my last comment was jftr ;)
> 
>>> But overriding things
>>> in bloodhound.css quickly becomes quite cumbersome, as there is no way
>>> to express "inheritance" of one tag's properties from another tag and
>>> then overriding some of them (you have to copy and paste the whole
>>> style).
>>> 
> 
> +1
> 
>>> However - bootstrap is built with LESS (http://lesscss.org/), which
>>> extends
>>> the CSS with variables etc. which would allow just that (via mixins).
>>> 
>> 
>> Oh, very cool, thank you for sharing that.
>> 
> 
> that's cool
> 
>>> Maybe we could adopt using LESS for building our custom bootstrap.css in
>>> the future?
>>> 
>> 
>> Do you mean, build bloodhound.css with LESS?
>> 
> 
> I suppose that's what Matevz meant in first place . If so , that's
> interesting . IMO we really have to assess the benefits vs the
> drawbacks . In principle I wouldn't mind *if* we were in need of
> relying upon LESS quite often and in considerable amounts (e.g. like
> Bootstrap ;) . Maybe we end-up building a space rocket to kill a
> single ant .

+1, it's more of an "if" thing. Currently bootstrap defaults suffice,
there is some CSS copy&pasting, but it's not really overwhelming.
If we ever want to change the default styling, or even enable the users
to do so, it may be a thing to consider.

> -- 
> Regards,
> 
> Olemis.


Mime
View raw message