Mailing-List: contact bloodhound-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: bloodhound-dev@incubator.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
MIME-Version: 1.0
In-Reply-To: 
 <CAKoya90kZMSkPQJ+zH3TV92UV=cntsX=mXyeJ3uYO8fVmKHQyA@mail.gmail.com>
References: 
 <CAGMZAuPPhjfGx4QgKz_-5udbGncr4PSp-n=xXYO7N0cMkko4jw@mail.gmail.com>
	<CAHM0gngAMBS8DGYfTc4q5R3rv6A8x6GS1mHLHNEoU3KVQ2davA@mail.gmail.com>
	<CAKoya90kZMSkPQJ+zH3TV92UV=cntsX=mXyeJ3uYO8fVmKHQyA@mail.gmail.com>
Date: Tue, 22 Jan 2013 16:35:22 +0100
Message-ID: 
 <CAHM0gnhXpp4-xRykKXniEgijYN5wnHj6nyTnPTHXbjcXx=1EbA@mail.gmail.com>
Subject: Re: [BEP-0003] [RFC] Permissions in product scope
From: Andrej Golcov <andrej@digiverse.si>
To: bloodhound-dev@incubator.apache.org
Content-Type: text/plain; charset=ISO-8859-1

Let's take a use case.
Do we want to allow a ProductAdmin to change workflow for the product
and do we want to use existing plugins for this purposes?
If the answer is yes, let's assume, that we decided to use
TracWorkflowAdminPlugin [1] for this purpose.

If we look in TracWorkflowAdminPlugin code [2] we can see:
...
class TracWorkflowAdminModule(Component):
    implements(IAdminPanelProvider, ITemplateProvider,
               IEnvironmentSetupParticipant)
...
    # IAdminPanelProvider methods
    def get_admin_panels(self, req):
        if 'TRAC_ADMIN' in req.perm:
            yield ('ticket', dgettext("messages", ("Ticket System")),
                   'workflowadmin', _("Workflow Admin"))
...

As far as I understand the code,  (TRAC_ADMIN' in req.perm) should be
True if we want the plugin working.
So far, we discussed two possibilities how to solve the problem:
 - ProductAdmin has TRAC_ADMIN permission for product environment
 - ProductAdmin has PRODUC_ADMIN permission but in some circumstances
('TRAC_ADMIN' in req.perm) still returns True.

For sure, there is possibility that I'm missing some important things.

[1] https://trac-hacks.org/wiki/TracWorkflowAdminPlugin
[2] https://trac-hacks.org/browser/tracworkflowadminplugin/0.12/tracworkflowadmin/web_ui.py