Mailing-List: contact bloodhound-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: bloodhound-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of olemis@gmail.com designates
 209.85.210.172 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <070.c3473d6147ba2cbe9e7f157e30c98a4a@incubator.apache.org>
References: <055.55b84508f6fcc1a8cc545a03456faa21@incubator.apache.org>
	<070.c3473d6147ba2cbe9e7f157e30c98a4a@incubator.apache.org>
Date: Mon, 14 Jan 2013 10:09:48 -0500
Message-ID: 
 <CAGMZAuME8Z6WYDU0-XqA5L4h1mEvQjK1sS2DUZ4PUupdGC1iTw@mail.gmail.com>
Subject: Re: [Apache Bloodhound] #115: Product-specific settings
From: Olemis Lang <olemis@gmail.com>
To: bloodhound-dev@incubator.apache.org
Content-Type: text/plain; charset=ISO-8859-1

On 1/14/13, Apache Bloodhound <bloodhound-dev@incubator.apache.org> wrote:
> #115: Product-specific settings
> -------------------------+-------------------------------------------------
>   Reporter:  olemis      |      Owner:  gjm
>       Type:              |     Status:  review
>   enhancement            |  Milestone:
>   Priority:  major       |    Version:
>  Component:              |   Keywords:  multiproduct environment
>   multiproduct           |  configuration database bep-0003 db-upgrade
> Resolution:              |  model
> -------------------------+-------------------------------------------------
>
> Comment (by jure):
>
>  Replying to [comment:7 olemis]:
>  > [attachment:t115_r1431447_product_envs_bep3_p1.diff Attached patch]
>  implements a number of enhancements aimed at complying with bep:0003
>  specification . This includes :
>  >
>  >   - Type checking in product env initializer
>
>  This tests parent against trac.env.Environment. After the hooks are in
>  place the proper type of the parent environment should be
>  multiproduct.env.Environment.
>

I kept trac.env.Environment because it's the common ancestor of both
your class and trac.test.EnvironmentStub .

>  > I also spent some time to build [https://bitbucket.org/olemis
>  /bloodhound-
> mq/src/t115_bep3_product_env/t115/t115_r1431447_product_envs_bep3_p1.diff?at=t115_bep3_product_env
>  another patch] rebasing product environments solution against
>  `bep_0003_,multiproduct` branch .
>  >
>
>  Great, will try to commit the patch today as tests are passing after
>  r1432924 (see below).
>

Great !
I'll take a look and , if everything starts working on
bep_0003_multiproduct branch then I won't post patches for trunk no
more .

>  > {{{
>  > #!sh
>  >
>  > $ python setup.py test -m tests.env
>  > [...]
>  > Testing env.get_known_users ... ERROR
>  > Testing env.get_version ... ERROR
>  > test_attr_forward_parent (tests.env.ProductEnvApiTestCase) ... ok
>  > test_typecheck (tests.env.ProductEnvApiTestCase) ... ERROR
>  >
>  > [...]
>  >
>  > ----------------------------------------------------------------------
>  > Ran 4 tests in 7.610s
>  >
>  > FAILED (errors=3)
>  >
>  > }}}
>  >
>  > ... so even if solution works it is not quite ready to be committed in
>  that branch yet .
>
>  Tests are now passing after r1432924 ... there was code in Product.insert
>  that would auto populate product tables (components, milestones, versions,
>  etc.) upon product insertion. This should actually be performed by a
>  higher level logic (admin interface for example).
>

we r almost there ... ;)

-- 
Regards,

Olemis.

Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/

Featured article: