Mailing-List: contact bloodhound-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: bloodhound-dev@incubator.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
Message-ID: <50ED4B83.7050208@digiverse.si>
Date: Wed, 09 Jan 2013 11:50:43 +0100
From: Jure Zitnik <jure@digiverse.si>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: bloodhound-dev@incubator.apache.org
Subject: Re: [Apache Bloodhound] #115: Product-specific settings
References: <055.55b84508f6fcc1a8cc545a03456faa21@incubator.apache.org>
 <070.15b8ebe71bafa7ae651d57d105b756d7@incubator.apache.org>
 <CAGMZAuM635pU5wQ=0-f-_5=TS=-Oy3-J0r34BrQ75TWpc=A4HQ@mail.gmail.com>
 <50D42A23.20005@digiverse.si>
 <CAGMZAuPO9N_fBbv=dCa3taUGVJuvitVVtyQ3sMVd5UCOK1T1RQ@mail.gmail.com>
In-Reply-To: 
 <CAGMZAuPO9N_fBbv=dCa3taUGVJuvitVVtyQ3sMVd5UCOK1T1RQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 1/8/13 9:07 AM, Olemis Lang wrote:
> On 12/21/12, Jure Zitnik <jure@digiverse.si> wrote:
>> On 12/20/12 10:26 PM, Olemis Lang wrote:
>>> On 12/19/12, Apache Bloodhound <bloodhound-dev@incubator.apache.org>
>>> wrote:
>>>>    I'll be developing this in [https://bitbucket.org/olemis/bloodhound-mq
>>>> my
>>>>    patch queue @ Bitbucket] in [https://bitbucket.org/olemis/bloodhound-
>>>>    mq/commits/all/tip/branch(%22t115_product_env%22) branch
>>>> t115_product_env]
>>>>
>>> Today I have submitted new versions of these patches (in branch
>>> t115_product_env ) aimed at running tests for Trac environments
>>> against product environments .
>> Great, will take a look.
> it's done now , so enjoy !
> ;)

I commited patches in r1430768.

I started integrating ProductEnvironment with the database proxy (#288), 
environment factory (#322) and global hooks (#323).

A question re ProductEnvironment class - is there a specific reason for 
that class not being derived directly from trac.env.Environment? I'm 
asking this as I was planning on replacing (monkey patching) 
trac.env.Environment with our implementation of the environment. This 
way we have control over database connection in all environments (global 
and per product). Making that (our env) a base class for 
ProductEnvironment would make things more consistent.

Also, I was thinking of renaming ProductEnvironment.env to 
ProductEnvironment.parent or ProductEnvironment.global (as set forth in 
BEP-0003). What's your take on this, do you have any objections?

>> any chance of rebasing those patches
>> against the multiproduct branch (bep_0003_multiproduct)?
> of course . IMO they should work with no or little modifications ...
> especially depending on base version (common ancestor) of
> bep_0003_multiproduct with respect to trunk . Do you merge changes in
> trunk relatively often ?

Thanks for the rebase. Until yesterday the trunk merge frequency was 
rather low but is set to increase ;)


> so it is the other way round . What's the next step for multi-product
> support ? What shall I do ?

Next step for the multi-product is the integration I'm working on at the 
moment (mentioned above). Depending on how this goes we'll see where to 
head next ... there are already number of tickets re UI changes related 
to multi-product (324-329) so that'd be the most obvious way.

Cheers,
Jure