Mailing-List: contact bloodhound-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: bloodhound-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of ryan.ollos@wandisco.com
 designates 209.85.223.169 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAPt9QwS-53q2P4CDe3gb8BZ=yDXCsK2pbgv01EKdA47y3jv=gw@mail.gmail.com>
References: 
 <CAKE9Bs-8vonCB7idTJGLAYd=1MmBYxQwRVcYkeW3KSLWg7-dZA@mail.gmail.com>
	<CAPt9QwT+kmebqzhw-kxZtbdX5nwBRTUtQOpqOro6gGOSPCnS9A@mail.gmail.com>
	<CAKE9Bs-_49FFBn7nm9uNXSNYGFfRJ-QsTKgxadL+-CaNTpBmaw@mail.gmail.com>
	<CAGMZAuMH_bjnUJf-Y3xjCmTkk7OT0VFdcfmvgcFP6ncSL706Lg@mail.gmail.com>
	<508A4CAB.3070106@digiverse.si>
	<CAPt9QwS6E7tVEHHQZ8PZy37rRs77=LiL-RbjFJ5MhTQMBTU2Ew@mail.gmail.com>
	<CAGMZAuO6RVoTKk7RyqJC+n9fNmHNJ18XeV5_U9OMX2P+NX+4yw@mail.gmail.com>
	<CAPt9QwS-53q2P4CDe3gb8BZ=yDXCsK2pbgv01EKdA47y3jv=gw@mail.gmail.com>
Date: Wed, 19 Dec 2012 00:34:34 -0800
Message-ID: 
 <CAPt9QwRU3unS9AAR3ritt6cXFN+7QCQ5xseTAGtX00JR9YZJiw@mail.gmail.com>
Subject: Re: Datamodel and data consistency
From: Ryan Ollos <ryan.ollos@wandisco.com>
To: bloodhound-dev@incubator.apache.org
Content-Type: multipart/alternative; boundary=e89a8f646e0deae78504d1307b39

--e89a8f646e0deae78504d1307b39
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 7, 2012 at 9:20 AM, Ryan Ollos <ryan.ollos@wandisco.com> wrote:

> On Fri, Oct 26, 2012 at 12:36 PM, Olemis Lang <olemis@gmail.com> wrote:
>
>> [...]
>> What you are doing over there seems to be exactly like batch
>> modifications . isn't it better to reuse batch modification code in
>> query module and make the whole thing to look exactly like if logged
>> in user had selected target tickets , set product=3Dnew_product and
>> comment field set to something like =ABRenaming product XXX to YYY =BB?
>>
>
> I had studied the BatchModify class when starting that implementation and
> it looked like the BatchModify class would need some changes in order to
> directly utilize the it. The patch I've implemented does "make the whole
> thing to look exactly like if logged in user had selected target tickets"=
,
> however I could see the advantage of code reuse from batch modify.
> Initially I dismissed this because I didn't want to dip into modifying th=
e
> BatchModify class, but I will revisit this issue and post some comments t=
o
> t.e.o ticket #4582 to see what the Trac developers have to say.
>

I've submitted a new patch which reuses code from the BatchModifyModule
class. I'll be interested to see what feedback the core developers have on
these changes. Please comments on that ticket if you have any suggestions
with regard to the implementation.

http://trac.edgewall.org/ticket/5658#comment:20

--e89a8f646e0deae78504d1307b39--