Return-Path: 
 <bloodhound-dev-return-1393-apmail-incubator-bloodhound-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-bloodhound-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-bloodhound-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id E2041DF12
	for <apmail-incubator-bloodhound-dev-archive@minotaur.apache.org>;
 Fri,  7 Dec 2012 17:53:24 +0000 (UTC)
Received: (qmail 97343 invoked by uid 500); 7 Dec 2012 17:53:24 -0000
Delivered-To: apmail-incubator-bloodhound-dev-archive@incubator.apache.org
Received: (qmail 97322 invoked by uid 500); 7 Dec 2012 17:53:24 -0000
Mailing-List: contact bloodhound-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:bloodhound-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:bloodhound-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:bloodhound-dev@incubator.apache.org>
List-Id: <bloodhound-dev.incubator.apache.org>
Reply-To: bloodhound-dev@incubator.apache.org
Delivered-To: mailing list bloodhound-dev@incubator.apache.org
Received: (qmail 97310 invoked by uid 99); 7 Dec 2012 17:53:24 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Dec 2012 17:53:24 +0000
X-ASF-Spam-Status: No, hits=-0.7 required=5.0
	tests=RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: domain of jangel.franco@gmail.com
 designates 209.85.212.47 as permitted sender)
Received: from [209.85.212.47] (HELO mail-vb0-f47.google.com) (209.85.212.47)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Dec 2012 17:53:18 +0000
Received: by mail-vb0-f47.google.com with SMTP id e21so662914vbm.6
        for <multiple recipients>; Fri, 07 Dec 2012 09:52:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=UX9GQr3AxCAP1ENvzsdoR43SNECpDSEjOHgf4sie5b8=;
        b=rnhMM+0uY1+KUGbH/6tZk3uKtYz/7FWjsmLiTZ549DujUhzj+iWeBRNmQtKLpxaww5
         Ojoaw3KmNP568to0VmQ3gTqtq5fFhAnevNSzxH7m9OBVsVHaPxLPeYW0N8Qu850C3Mle
         etISWq9FrSWkPSYswzAYsaRwgZVVn+Uxl6DQjwJeN9BeC+le73Vjoe8ND8Gx9ubM6Ko8
         GYbTqxUmoD27Pd860+gguMDbtPMJlYHjHuX+Zw39S7sX2bfcUd4F9N7vSSDp1GyxEZZ4
         xjZsYp7iYpPWU3j0zBNueicYZT3CDYUia9v0E2fhOHNRwVwvnleM11+CyIIaVW8h8z0d
         8KsQ==
MIME-Version: 1.0
Received: by 10.52.75.70 with SMTP id a6mr3733369vdw.6.1354902777149; Fri, 07
 Dec 2012 09:52:57 -0800 (PST)
Received: by 10.58.40.6 with HTTP; Fri, 7 Dec 2012 09:52:56 -0800 (PST)
In-Reply-To: <070.52db32600a6191aa4c74cc548fe59c49@incubator.apache.org>
References: <055.adb087c439202d01cc374ec308ab1d80@incubator.apache.org>
	<070.52db32600a6191aa4c74cc548fe59c49@incubator.apache.org>
Date: Fri, 7 Dec 2012 12:52:56 -0500
Message-ID: 
 <CAJpvC4K2QMQ2qHJtRJExtRZvH1tAnvZsPQ1YK2Kedd7pPu9uQw@mail.gmail.com>
Subject: Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to
 dashboard plugin
From: Jose Angel Franco Navarro <jangel.franco@gmail.com>
To: bloodhound-dev@incubator.apache.org
Cc: bloodhound-commits@incubator.apache.org
Content-Type: text/plain; charset=ISO-8859-1
X-Virus-Checked: Checked by ClamAV on apache.org

Hi there,
Until further discussion takes place, and it get to be finally decided
if creating the new bloodhound_core directory, I have submitted two
new revisions 9e3ae4c , d391096 to my branches moving ModelBase to
model.py as accurately observed by rjollos.

Best regards,
Franco.


2012/12/7, Apache Bloodhound <bloodhound-dev@incubator.apache.org>:
> #280: Move multiproduct.model.ModelBase to dashboard plugin
> ---------------------------+------------------------------------
>   Reporter:  olemis        |      Owner:  franco
>       Type:  enhancement   |     Status:  accepted
>   Priority:  trivial       |  Milestone:
>  Component:  multiproduct  |    Version:
> Resolution:                |   Keywords:  database model testing
> ---------------------------+------------------------------------
>
> Comment (by olemis):
>
>  Replying to [comment:5 rjollos]:
>  > I haven't seen the previous discussion in which it was decided to move
>  common components to dashboard,
>
>  There's no such record since that was one of the first decisions we made
>  about Bloodhound . I'm not even sure we had neither mailing lists setup
>  nor even project page at the time .
>
>  > but my initial impression is that it doesn't make much more sense to
>  have them in dashboard than in multiproduct.
>  > I had a brief discussion about this with gjm this evening, and we both
>  think it might make sense to move the components to a new
>  `bloodhound_core` directory.
>
>  At the time there was no much time to create and manage a new
>  bloohound_core directory that noone knew what'd happen with it in the
>  future . After considering both options we decided that shared assets
>  would be placed in dashboard because all other plugins already depended
>  upon it (for widgets).
>
>  > I  also think that `ModelBase.py` should be in `model.py` rather than
>  `db.py`. My understanding is that only the schema and environment upgrade
>  hooks should be in `db.py`.
>  >
>
>  +1
>
>  > I've committed the fixes for the test cases in r1418224. Thank you
>  franco and olemis!
>
>  A big thank you for taking the the time to review and commit .
>  :)
>
> --
> Ticket URL: <https://issues.apache.org/bloodhound/ticket/280#comment:6>
> Apache Bloodhound <https://issues.apache.org/bloodhound/>
> The Apache Bloodhound (incubating) issue tracker
>