Return-Path: X-Original-To: apmail-incubator-bloodhound-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-bloodhound-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C64E1D85E for ; Sun, 2 Dec 2012 23:53:23 +0000 (UTC) Received: (qmail 81826 invoked by uid 500); 2 Dec 2012 23:53:22 -0000 Delivered-To: apmail-incubator-bloodhound-dev-archive@incubator.apache.org Received: (qmail 81800 invoked by uid 500); 2 Dec 2012 23:53:22 -0000 Mailing-List: contact bloodhound-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: bloodhound-dev@incubator.apache.org Delivered-To: mailing list bloodhound-dev@incubator.apache.org Received: (qmail 81754 invoked by uid 99); 2 Dec 2012 23:53:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Dec 2012 23:53:22 +0000 X-ASF-Spam-Status: No, hits=2.8 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS,URIBL_BLACK X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of olemis@gmail.com designates 209.85.220.175 as permitted sender) Received: from [209.85.220.175] (HELO mail-vc0-f175.google.com) (209.85.220.175) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Dec 2012 23:53:16 +0000 Received: by mail-vc0-f175.google.com with SMTP id fy7so1291295vcb.6 for ; Sun, 02 Dec 2012 15:52:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=yZEthR9/p8kBm2K+70mSzWQvw6HQYoYkhuo/iWErZa8=; b=oY61s10TACyAqGQiGTYYLeSn6eW6KbUlqhkgZNxMgzA/77JQakYayh4QObkwkaG5qL 8erO/Bg98FAPFlWJBJJPTbZmWT/VDy9bwhvsMU/aNMQBcDSuyb+9BdlIH1fs6ezSY3hr iZYM7XhYc92F/dz9lKmAAtwuo4VhiDg0w6y1+zXUbCTJaK8TDiC2poq6CwZahX1dk38j v1DLgSOY07BFt9zbOp9GuOvm3tPhqAW0n1UGGwG7vWYKeVuAzPL5Cq2ZtbZuMShDYdHy poDSx+Hb3WQCZrHjcn4LtfsyjWXlArEo88E2N5VQiavZGWDYkoB3QfbMv1nPfuWbtjcp PWaQ== MIME-Version: 1.0 Received: by 10.52.75.105 with SMTP id b9mr6283129vdw.28.1354492375704; Sun, 02 Dec 2012 15:52:55 -0800 (PST) Received: by 10.58.156.71 with HTTP; Sun, 2 Dec 2012 15:52:55 -0800 (PST) In-Reply-To: References: <2BA32F18-E010-433A-8E9F-359192ABA8F8@wandisco.com> Date: Sun, 2 Dec 2012 18:52:55 -0500 Message-ID: Subject: Re: Genshi XHTML + HTML 5 From: Olemis Lang To: bloodhound-dev@incubator.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org Hi ! On 12/2/12, Matevz Bradac wrote: > I tried solving this on the stream level, but no luck so far. However you have been doing an extraordinary research here . Good work . :) [...] > > Due to the above complications (and those not yet discovered), I'd say > it would be easier and less error-prone > to just override the genshi.output.get_serializer() with BH's wrapper. > The function is pretty trivial and unlikely > to change much, so it looks like a safe alternative. > I'm not very aware of the details . Nonetheless I'd just say for the moment that there's more chance to accept a patch (i.e. not monkeypatching ;) for Chrome.render_template than another for Genshi . In the end we are already distributing a modified copy of Trac , so patches of this kind are welcome , especially if there's a good reason to do so . So at this point don't be afraid of proposing a refactoring for that method in order to be able to choose another doctype . Just try to keep it as compatible with previous solution as possible , since there is no need to break Trac if e.g. Bloodhound theme is disabled OTOH creating another vendor branch for Genshi is quite unlikely to happen soon . Keep up the good work ! ;) -- Regards, Olemis. Blog ES: http://simelo-es.blogspot.com/ Blog EN: http://simelo-en.blogspot.com/ Featured article: