Mailing-List: contact bloodhound-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: bloodhound-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of gary.martin@wandisco.com
 designates 209.85.214.47 as permitted sender)
Message-ID: <50C09101.2050002@wandisco.com>
Date: Thu, 06 Dec 2012 12:35:13 +0000
From: Gary Martin <gary.martin@wandisco.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: bloodhound-dev@incubator.apache.org
Subject: Re: [Apache Bloodhound] #285: Create prototype for improved search
 architecture (BEP-0004)
References: <055.cd6898b187849ba108614f7a75832ac5@incubator.apache.org>
 <070.775dcbb1d20351d170d8dea1825a3bf6@incubator.apache.org>
 <CAHM0gngP+NHACfqk2eTYpADS60iGgC9ja23727cDsaGvMsZmwA@mail.gmail.com>
 <50BF7CDE.10205@wandisco.com>
In-Reply-To: <50BF7CDE.10205@wandisco.com>
Content-Type: multipart/alternative;
 boundary="------------010800010206060306070208"

--------------010800010206060306070208
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 05/12/12 16:57, Gary Martin wrote:
> On 05/12/12 16:17, Andrej Golcov wrote:
>> Hi,
>>
>> I attached patch for initial setup of Bloodhound Search plugin. It is
>> just initial skeleton:
>> https://issues.apache.org/bloodhound/attachment/ticket/285/bloodhound_search_plugin_skeleton_towards_%23285.patch 
>>
>> The idea is that, until code is stable enough, plugin exists only in
>> development environment and must be disabled by default. A developer
>> have to enable it manually.
>>
>> This is my first Bloodhound plugin and I would kindly ask to review it
>> before any additional logic is added.
>>
>> Regards, Andrej
>
> Cool.. on my habitual search for license headers, I note that 
> bloodhound_search/bhsearch/templates/bhsearch.html is lacking one. 
> Only a reminder really.. I'll be happy to add the appropriate text for 
> you.
>
> Anyway, I'll give it a quick look over and see if I can commit it a 
> bit later.
>
> Cheers,
>     Gary

Right.. happy for that to go in as a start - I hope you don't mind that 
I included a quick fix to make sure that the empty query doesn't result 
in a complaint about concatenating strings with None.

So, that is committed in revision 1417813.

Cheers,
     Gary

--------------010800010206060306070208--