incubator-bloodhound-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jose Angel Franco Navarro <jangel.fra...@gmail.com>
Subject Re: Ticket #280 implemented
Date Wed, 05 Dec 2012 21:50:34 GMT
I believe the ticket is ready to put it into review state.

Test cases are running with no faults, and the functional tests I
mentioned for CRUD operations on /products page were black box tests
covering basic functionalities involved on the refactoring:

I created a product, updated it later, then I made a search and loaded
the product created, and finally I deleted the product. I also made a
similar test verifying validation of duplicate prefix and name.

Everything seems to be working properly, so yes, you might put it into
 review state.

It’s very gratifying to hear from you so soon.

Best regards,

Franco.

2012/12/5, Olemis Lang <olemis@gmail.com>:
> On 12/5/12, Jose Angel Franco Navarro <jangel.franco@gmail.com> wrote:
>> Hello everyone!
>
> :)
>
>> My name is Jose Angel Franco, I recently  joined the community and I’m
>> interested in contributing to  bloodhound.
>>
>
> cool !
> I'm hoping that at least you could provide us with some feedback about
> running Apache™ Bloodhound on Windows .
>
>> I picked up ticket # 280,
>
> good !
> I'll assign it back to you then
> ;)
>
>> and submitted the solution to my  BitBucket
>> forks:
>> https://bitbucket.org/jose_angel_franco/bloodhound-dashboard/
>> https://bitbucket.org/jose_angel_franco/bloodhound_multiproduct/
>>
>
> Is it ok to mention root repos in BloodhoundContributing as an option
> for new contributors ?
>
>> I  created a branch for this ticket on each repo to make it easier to
>> diff from  it. Both branches are named the  same
>> (t280_move_modelbase_to_dashboard)
>>
>> You can take a look at the diff as follows
>>
>> https://bitbucket.org/jose_angel_franco/bloodhound-dashboard/compare/t280_move_modelbase_to_dashboard..default
>>
>> https://bitbucket.org/jose_angel_franco/bloodhound_multiproduct/compare/t280_move_modelbase_to_dashboard..default
>>
>
> good !
> I'll add those URLs in #280 as well .
>
> Is it done ? I mean may I put that ticket into review state instead of
> assigning it to you for further improvements ?
>
>> Solution  summary:
>
> +1 for all the work you've done in there so far
> ;)
>
> [...]
>>
>> After these minor adjustments the  test cases are all up and running.
>>
>
> u rock !
> :)
>
>> I made some functional tests as well,  on the /products page,
>> considering all CRUD transactions and everything is  working OK.
>>
>
> ok for now basic unit tests are enough . Automation of more
> sophisticated functional test cases is on our schedule though .
>
> Happy hacking !
>
> --
> Regards,
>
> Olemis.
>
> Blog ES: http://simelo-es.blogspot.com/
> Blog EN: http://simelo-en.blogspot.com/
>
> Featured article:
>

Mime
View raw message