incubator-bloodhound-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jose Angel Franco Navarro <jangel.fra...@gmail.com>
Subject Ticket #280 implemented
Date Wed, 05 Dec 2012 20:31:11 GMT
Hello everyone!
My name is Jose Angel Franco, I recently  joined the community and I’m
interested in contributing to  bloodhound.

I picked up ticket # 280, and submitted the solution to my  BitBucket forks:
https://bitbucket.org/jose_angel_franco/bloodhound-dashboard/
https://bitbucket.org/jose_angel_franco/bloodhound_multiproduct/

I  created a branch for this ticket on each repo to make it easier to
diff from  it. Both branches are named the  same
(t280_move_modelbase_to_dashboard)

You can take a look at the diff as follows

https://bitbucket.org/jose_angel_franco/bloodhound-dashboard/compare/t280_move_modelbase_to_dashboard..default

https://bitbucket.org/jose_angel_franco/bloodhound_multiproduct/compare/t280_move_modelbase_to_dashboard..default

Solution  summary:
ModelBase class and two utility functions used by it were moved to  a
more general module on dashboard plugin: bhdashboard/db.py.

Imports  were adjusted in multiproduct/model.py to refer to the new
module  bhdashboard/db.py

Validating the correctness of the refactoring I ran the  tests in
ProductTestCase of the multiproduct plugin, and found a bug related  to
the use of multiproduct.model .MultiProductEnvironmentProvider  wich
had to be substituted by  multiproduct.api.MultiProductSystem

Once the import was fixed, some  test cases were failing due to
duplicate product name on test data, I varied  the names of the
products and it worked. Then some other tests failed, but  now due to
assertions not matching new conditions related to the name of  the
products that were just changed.

After these minor adjustments the  test cases are all up and running.

I made some functional tests as well,  on the /products page,
considering all CRUD transactions and everything is  working OK.

Best regards

Mime
View raw message