incubator-bloodhound-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Olemis Lang <ole...@gmail.com>
Subject Re: Ticket #280 implemented
Date Wed, 05 Dec 2012 21:21:11 GMT
On 12/5/12, Jose Angel Franco Navarro <jangel.franco@gmail.com> wrote:
> Hello everyone!

:)

> My name is Jose Angel Franco, I recently  joined the community and I’m
> interested in contributing to  bloodhound.
>

cool !
I'm hoping that at least you could provide us with some feedback about
running Apache™ Bloodhound on Windows .

> I picked up ticket # 280,

good !
I'll assign it back to you then
;)

> and submitted the solution to my  BitBucket
> forks:
> https://bitbucket.org/jose_angel_franco/bloodhound-dashboard/
> https://bitbucket.org/jose_angel_franco/bloodhound_multiproduct/
>

Is it ok to mention root repos in BloodhoundContributing as an option
for new contributors ?

> I  created a branch for this ticket on each repo to make it easier to
> diff from  it. Both branches are named the  same
> (t280_move_modelbase_to_dashboard)
>
> You can take a look at the diff as follows
>
> https://bitbucket.org/jose_angel_franco/bloodhound-dashboard/compare/t280_move_modelbase_to_dashboard..default
>
> https://bitbucket.org/jose_angel_franco/bloodhound_multiproduct/compare/t280_move_modelbase_to_dashboard..default
>

good !
I'll add those URLs in #280 as well .

Is it done ? I mean may I put that ticket into review state instead of
assigning it to you for further improvements ?

> Solution  summary:

+1 for all the work you've done in there so far
;)

[...]
>
> After these minor adjustments the  test cases are all up and running.
>

u rock !
:)

> I made some functional tests as well,  on the /products page,
> considering all CRUD transactions and everything is  working OK.
>

ok for now basic unit tests are enough . Automation of more
sophisticated functional test cases is on our schedule though .

Happy hacking !

-- 
Regards,

Olemis.

Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/

Featured article:

Mime
View raw message