incubator-bloodhound-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Olemis Lang <ole...@gmail.com>
Subject Re: #217 - Make Bloodhound's layout responsive
Date Fri, 21 Dec 2012 00:20:10 GMT
On 12/20/12, Matevz Bradac <matevzb@gmail.com> wrote:
> On Wed, Dec 19, 2012 at 10:50 PM, Olemis Lang <olemis@gmail.com> wrote:
>> On 12/19/12, Matevz Bradac <matevzb@gmail.com> wrote:
>>
[...]
>>
>>> I've currently implemented this by having
>>> two
>>> types of templates (responsive- and old-style), and BloodhoundTheme's
>>> __init__
>>> then checks for a specific trac.ini setting and switches to whatever is
>>> set.
>>
>> If you are using options in trac.ini I suggest you to make that
>> decision in theme's post_process_request instead because :
>>
[...]
>
> Good catch, I missed this one.

yes, otherwise it might be even necessary to restart the server to
switch between them .
;)

> Are there any special considerations within
> post_process_request(), before or after switching the template?
>

I'm not sure I understood your question ...

[...]
>
>> I could work side-by side with you by
>> reviewing everything in detail and improving timeline widget for all
>> this transitions to happen smoothly .
>
> I'll first prepare a proposal/patch and attach it to the ticket if that's
> okay.

ok . I just didn't know you had commit access .

-- 
Regards,

Olemis.

Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/

Featured article:

Mime
View raw message