incubator-bloodhound-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Martin <gary.mar...@wandisco.com>
Subject Re: [Apache Bloodhound] #285: Create prototype for improved search architecture (BEP-0004)
Date Thu, 06 Dec 2012 12:35:13 GMT
On 05/12/12 16:57, Gary Martin wrote:
> On 05/12/12 16:17, Andrej Golcov wrote:
>> Hi,
>>
>> I attached patch for initial setup of Bloodhound Search plugin. It is
>> just initial skeleton:
>> https://issues.apache.org/bloodhound/attachment/ticket/285/bloodhound_search_plugin_skeleton_towards_%23285.patch

>>
>> The idea is that, until code is stable enough, plugin exists only in
>> development environment and must be disabled by default. A developer
>> have to enable it manually.
>>
>> This is my first Bloodhound plugin and I would kindly ask to review it
>> before any additional logic is added.
>>
>> Regards, Andrej
>
> Cool.. on my habitual search for license headers, I note that 
> bloodhound_search/bhsearch/templates/bhsearch.html is lacking one. 
> Only a reminder really.. I'll be happy to add the appropriate text for 
> you.
>
> Anyway, I'll give it a quick look over and see if I can commit it a 
> bit later.
>
> Cheers,
>     Gary

Right.. happy for that to go in as a start - I hope you don't mind that 
I included a quick fix to make sure that the empty query doesn't result 
in a complaint about concatenating strings with None.

So, that is committed in revision 1417813.

Cheers,
     Gary

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message