Mailing-List: contact bloodhound-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: bloodhound-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of joachim.dreimann@wandisco.com
 designates 209.85.214.47 as permitted sender)
Subject: Re: [Apache Bloodhound] #252: Add dismiss functionality to all alert
 messages
References: <055.c8eaa10bb025d2e3f9b834a129ef307b@incubator.apache.org>
 <070.75ce3655aa28cbe618cc23cbcdf6220c@incubator.apache.org>
 <CAPt9QwSvtZyM__S8RaCOMaG1vKPw7izLAh_=p=f-PXw4uZeajA@mail.gmail.com>
 <CAGMZAuPwJPne9fTxR=pR5ayX-YYbY2RFd4fZ5bppqNr3Hj5o3w@mail.gmail.com>
From: Joe Dreimann <joachim.dreimann@wandisco.com>
Content-Type: text/plain;
	charset=us-ascii
In-Reply-To: 
 <CAGMZAuPwJPne9fTxR=pR5ayX-YYbY2RFd4fZ5bppqNr3Hj5o3w@mail.gmail.com>
Message-Id: <506F9639-4E75-4920-BA61-F6E54CFB5337@wandisco.com>
Date: Thu, 8 Nov 2012 10:17:55 +0000
To: "bloodhound-dev@incubator.apache.org"
 <bloodhound-dev@incubator.apache.org>
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (1.0)

On 8 Nov 2012, at 03:34, Olemis Lang <olemis@gmail.com> wrote:

> [...] now that we use a lot of bootstrap js plugins at least in
> release tarballs I do suggest to include a single minified
> bootstrap.js file containing all plugins for better performance .

+1

> 
> On 11/7/12, Ryan Ollos <ryan.ollos@wandisco.com> wrote:
>> On Mon, Nov 5, 2012 at 1:00 AM, Apache Bloodhound <
>> bloodhound-dev@incubator.apache.org> wrote:
>> 
>>> #252: Add dismiss functionality to all alert messages
>>> --------------------------+------------------------------------------
>>>  Reporter:  olemis       |      Owner:  gjm
>>>      Type:  enhancement  |     Status:  review
>>>  Priority:  major        |  Milestone:  Release 3
>>> Component:  ui design    |    Version:
>>> Resolution:               |   Keywords:  bootstrap js system messages
>>> --------------------------+------------------------------------------
>>> Changes (by olemis):
>>> 
>>> * status:  accepted => review
>>> * owner:  olemis => gjm
>>> 
>>> 
>>> Comment:
>>> 
>>> Patch attached . Please review .
>> 
>> The patch looks good/works well for me. FWIW, I vote to apply it as is.
>> 
>> OT: Will files such as `dashboard/js/bootstrap-alert.js` eventually be
>> moved to `bloodhound_theme/bhtheme/js`? It seems like the bootstrap files
>> should be in the "theme" directory.
> 
> 
> -- 
> Regards,
> 
> Olemis.
> 
> Blog ES: http://simelo-es.blogspot.com/
> Blog EN: http://simelo-en.blogspot.com/
> 
> Featured article: