Mailing-List: contact bloodhound-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: bloodhound-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of gary.martin@wandisco.com
 designates 209.85.214.47 as permitted sender)
Message-ID: <506C4C5E.1090003@wandisco.com>
Date: Wed, 03 Oct 2012 15:31:58 +0100
From: Gary Martin <gary.martin@wandisco.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:15.0) Gecko/20120912 Thunderbird/15.0.1
MIME-Version: 1.0
To: bloodhound-dev@incubator.apache.org
Subject: Re: [Apache Bloodhound] #154: Installer fails when providing
 repository
 type without a path and vice versa
References: <052.25ce68ff140fb674f0c5dd2b6d5e2409@incubator.apache.org>
 <067.e9fa89bd1c0ad4a41dd2a4873426abb7@incubator.apache.org>
 <506C0CCF.8040005@wandisco.com>
 <CAPt9QwToZ3C7SpiD++-Et9c9RudtUi4nBBnEDtdUO4Sp5kRg4Q@mail.gmail.com>
In-Reply-To: 
 <CAPt9QwToZ3C7SpiD++-Et9c9RudtUi4nBBnEDtdUO4Sp5kRg4Q@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 03/10/12 14:38, Ryan Ollos wrote:
> On Wed, Oct 3, 2012 at 3:00 AM, Gary Martin <gary.martin@wandisco.com>wrote:
>
>> Hi Jure,
>>
>> Annoyingly it seems that adding attachments does not trigger email updates
>> so I missed your patch for this issue.
>>
>> Anyway, good job there. If you don't mind, I will expand on the error
>> message that you suggest.
>>
>> Cheers,
>>      Gary
>>
> Hi Gary,
>
> I thought there was an option to send notification when attachments are
> added, but I was thinking of my experience using the AnnouncerPlugin, which
> always sends an email when an attachment is added (1). It looks like there
> is a long-standing ticket in Trac for this feature. It one of those
> frustrating tickets that has has several patches generated, but never
> seemed to going anywhere for no obvious reason.
>
> (1) http://trac-hacks.org/wiki/AnnouncerPlugin
> (2) http://trac.edgewall.org/ticket/2259
>

Yeah, I spotted that ticket. I thought it might be worth waiting to see 
if there was a demand for this to be fixed.

For our purposes, it could be argued that it is the correct behaviour 
for https://issues.apache.org/bloodhound as it is probably better for 
the person proposing the patch to mention it here. It doesn't seem right 
more generally though. It may well be worth looking at the 
AnnouncerPlugin if it solves this and other problems. The CC behaviour 
mentioned in https://issues.apache.org/bloodhound/ticket/210 may be one 
of these cases.

Cheers,
     Gary