incubator-bloodhound-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Olemis Lang <ole...@gmail.com>
Subject Re: #190 (Was: Re: [Apache Bloodhound] #154: Installer fails when providing repository type without a path and vice versa)
Date Thu, 04 Oct 2012 17:28:50 GMT
On 10/4/12, Gary Martin <gary.martin@wandisco.com> wrote:
> On 04/10/12 13:53, Jure Žitnik wrote:
>> Hi Gary,
>>
>> On 10/3/12 12:00 PM, Gary Martin wrote:
>>> Hi Jure,
>>>
>>> Annoyingly it seems that adding attachments does not trigger email
>>> updates so I missed your patch for this issue.
>>
>> Another ticket that's pending proposed patch review is #190.
>
> Good point. Here is the link to that ticket for more information:
> https://issues.apache.org/bloodhound/ticket/190
>
> The fix is pretty simple and I don't see any particular problem with it.
>
> One thing worth noting is that I believe you can replace
>
>     more_link_href = req.href('query', args)
>
> with
>
>     more_link_href = req.href.query(args)
>

+1 ... just a matter of styles ; prefer using the later rather than
the former , except in cases like

more_link_href = req.href('query' if q else 'report', args)

-- 
Regards,

Olemis.

Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/

Featured article:

Mime
View raw message