incubator-bloodhound-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Martin <gary.mar...@wandisco.com>
Subject Re: [Apache Bloodhound] #236: Missing ticket keywords regression
Date Tue, 16 Oct 2012 12:47:59 GMT
Hi,

I spotted the missing keywords issue on trunk which is a result of 
changes introduced by #206.

I can't say for certain that the keywords should appear in the location 
they do, or that it is clear that they are keywords, but it would be 
nice for them to appear.

Cheers,
     Gary


On 16/10/12 13:44, Apache Bloodhound wrote:
> #236: Missing ticket keywords regression
> -----------------------+-----------------------
>   Reporter:  gjm        |      Owner:  nobody
>       Type:  defect     |     Status:  new
>   Priority:  major      |  Milestone:  Release 3
> Component:  dashboard  |    Version:
>   Keywords:             |
> -----------------------+-----------------------
>   I note that #206 resulted in the absence of the keywords display. I
>   believe that the following would fix the issue as the keywords field was
>   removed from the {{{fields}}} variable:
>
>   {{{
>   #!diff
>   Index: bhtheme/templates/bh_ticket_box.html
>   ===================================================================
>   --- bhtheme/templates/bh_ticket_box.html        (revision 1398220)
>   +++ bhtheme/templates/bh_ticket_box.html        (working copy)
>   @@ -61,10 +61,10 @@
>        </div>
>      </py:def>
>
>   -  <py:with vars="fields = [f for f in fields if not f.skip and f.name not
>   in ('type', 'owner', 'keywords')];
>   -      small_fields = [f for f in fields if f.type not in ('text',
>   'textarea') and f.name != 'cc'];
>   -      text_fields = [f for f in fields if f.type == 'text' or f.name ==
>   'cc'];
>   -      area_fields = [f for f in fields if f.type == 'textarea'];
>   +  <py:with vars="basefields = [f for f in fields if not f.skip and f.name
>   not in ('type', 'owner', 'keywords')];
>   +      small_fields = [f for f in basefields if f.type not in ('text',
>   'textarea') and f.name != 'cc'];
>   +      text_fields = [f for f in basefields if f.type == 'text' or f.name
>   == 'cc'];
>   +      area_fields = [f for f in basefields if f.type == 'textarea'];
>          _colcount = colcount or 6">
>        <div class="properties" style="margin: 1.2em 0px">
>          <py:with vars="_fields, csscls, count, fontsize, is_inline =
>   }}}
>
>   Alternatively we could just store the value of the keywords field before
>   it is removed from the fields.
>
> -- Ticket URL: <https://issues.apache.org/bloodhound/ticket/236> 
> Apache Bloodhound <https://issues.apache.org/bloodhound/> The Apache 
> Bloodhound (incubating) issue tracker


Mime
View raw message