Return-Path: X-Original-To: apmail-incubator-bloodhound-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-bloodhound-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 086E6DDDC for ; Wed, 19 Sep 2012 11:47:39 +0000 (UTC) Received: (qmail 84462 invoked by uid 500); 19 Sep 2012 11:47:38 -0000 Delivered-To: apmail-incubator-bloodhound-dev-archive@incubator.apache.org Received: (qmail 84400 invoked by uid 500); 19 Sep 2012 11:47:38 -0000 Mailing-List: contact bloodhound-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: bloodhound-dev@incubator.apache.org Delivered-To: mailing list bloodhound-dev@incubator.apache.org Received: (qmail 84379 invoked by uid 99); 19 Sep 2012 11:47:37 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Sep 2012 11:47:37 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of joachim.dreimann@wandisco.com designates 74.125.82.43 as permitted sender) Received: from [74.125.82.43] (HELO mail-wg0-f43.google.com) (74.125.82.43) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Sep 2012 11:47:30 +0000 Received: by wgbdq11 with SMTP id dq11so591259wgb.0 for ; Wed, 19 Sep 2012 04:47:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:content-type:message-id:mime-version:subject:date:references :to:in-reply-to:x-mailer:x-gm-message-state; bh=Ai9BMmbuB0zWf8H7eNfvLBveIAuNdga40q/xflKuVvw=; b=ZrM6XDbLj2rUjwqmPpoKwPISuHnlNugtfK3aCWFPtsz8nBLeK3X7/35sLm5yKobIrl 2G+bEcu8fgc27ZgtweBqEZj7LUkaQZJo/ZHPj8WRhoRoGJJiKqMcnTBK23rG734zKpJe MvpPuHOZhXNGAyg4AJmwPxQ3okc0YqVaMK6cu49Q8StQ1jY9qU5icivf3SD9YaDww76T 6B8mDGFvXZC6Y7+sHJIDO+LkcJha8vOZXDwJ8dgKgy0XcCj+k82nWgIbQgEFvliNy/jD qNayJDAB8T4/MLV+exJhWZDzjMUaEmWmOdGIIZza0ZEd9BPmH8PjyvqyE232D3YaEffd FKUg== Received: by 10.180.76.36 with SMTP id h4mr6380618wiw.13.1348055229095; Wed, 19 Sep 2012 04:47:09 -0700 (PDT) Received: from 10-2-5-142.dhcp.shef.wandisco.com ([77.86.30.139]) by mx.google.com with ESMTPS id hv8sm32022296wib.0.2012.09.19.04.47.06 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 19 Sep 2012 04:47:07 -0700 (PDT) From: Joachim Dreimann Content-Type: multipart/alternative; boundary="Apple-Mail=_79DA78F8-3E10-4B3E-91E4-AD30F85AB7D7" Message-Id: <5423CED3-7E10-48CB-B445-937F444457D4@wandisco.com> Mime-Version: 1.0 (Mac OS X Mail 6.0 \(1485\)) Subject: Re: [Apache Bloodhound] #187: Remove row count and results pagination from Dashboard Date: Wed, 19 Sep 2012 12:47:05 +0100 References: <058.556d561ac8118c74aff2b0380f421667@incubator.apache.org> <073.4e66acd1d3eab58cf63112d9a398a95c@incubator.apache.org> <50599857.30602@wandisco.com> <5059AB01.60704@wandisco.com> To: bloodhound-dev@incubator.apache.org In-Reply-To: <5059AB01.60704@wandisco.com> X-Mailer: Apple Mail (2.1485) X-Gm-Message-State: ALoCoQkEF7fxYl+19Qv/AZkcbQhTw2iDLXhv3xTphktSl+ny5JmM2Up6uUvRuqBfToj7tjM77Rhd --Apple-Mail=_79DA78F8-3E10-4B3E-91E4-AD30F85AB7D7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 I agree with displaying the total number - the More link could show "32 = More" for example to indicate how many more tickets there will be. = Alternatively we could show something like: More 42 Total I believe we should always show the more link though, not just = conditionally. It stands not just for 'more tickets', but also = represents 'more query options', 'more filtering' etc - functionality = that we may not want to duplicate on the Dashboard, and at least won't = in the short term. Cheers, Joe On 19 Sep 2012, at 12:22, Gary Martin wrote: > I agree that a user might want to know the total number of tickets = that are matching the query. I have not seen that feature in any = mock-ups though. As it was Joe's request, I hope he might comment on = this aspect. >=20 > Meanwhile thanks for the note about the "More" link. Discussions of = this may overlap a little with #190 which Jure is looking at. On the = other hand, I don't think that point is covered by #190 so I would = probably encourage you to raise a new ticket. >=20 > As for a possible answer to it: I don't suppose it would be missed if = the "More" link was shown conditionally. Although it could be considered = useful as a link to the appropriate query, the alternative of changing = the link text may just be confusing. >=20 > Cheers, > Gary >=20 >=20 > On 09/19/2012 11:26 AM, Peter Ko=9Eelj wrote: >> I'll just remove it then. >>=20 >> Another question: The task says we should remove total ticket number = as >> well. Is that correct? >> Information about a number of all tickets seem useful. >>=20 >> And a note: Should the "More" link really be there when there is less = than >> max number of tickets? >>=20 >> Cheers, >> Peter >>=20 >> On Wed, Sep 19, 2012 at 12:03 PM, Gary Martin = wrote: >>=20 >>> If there is a way for the paginator to make sense we could consider >>> keeping the code. I think it would only make sense if it updated the >>> tickets shown on the same page but it is not clear that we want that = at the >>> moment. >>>=20 >>> I would lean towards the second option. Although it might be = annoying, it >>> could always be reverted and adapted to a future behaviour. >>>=20 >>> Cheers, >>> Gary >>>=20 >>>=20 >>>=20 >>> On 09/19/2012 10:52 AM, Peter Ko=9Eelj wrote: >>>=20 >>>> There are two ways we can do this. >>>>=20 >>>> 1. We can add a "show_paginator" argument to the TicketQueryWidget = and set >>>> it to False for every widget instance on dashboard. >>>> The plus side is that this leaves as with the option to have = both >>>> style >>>> instances of the widget. >>>> The negative side is that we keep some dead code if we never = use the >>>> option with shown paginator. >>>>=20 >>>> 2. The simple solution is to simply remove the pagination stuff = from the >>>> widget_grid.html. >>>> As far as I can tell, the widget is not used outside the = dashboard >>>> anyway. >>>>=20 >>>> Peter >>>>=20 >>>> On Tue, Sep 18, 2012 at 1:18 PM, Apache Bloodhound < >>>> = bloodhound-dev@incubator.**apache.org= > >>>> wrote: >>>>=20 >>>> #187: Remove row count and results pagination from Dashboard >>>>> --------------------------+---**------------------- >>>>> Reporter: jdreimann | Owner: peter >>>>> Type: enhancement | Status: assigned >>>>> Priority: minor | Milestone: >>>>> Component: dashboard | Version: >>>>> Resolution: | Keywords: >>>>> --------------------------+---**------------------- >>>>> Changes (by gjm): >>>>>=20 >>>>> * status: new =3D> assigned >>>>> * owner: nobody =3D> peter >>>>>=20 >>>>>=20 >>>>> -- >>>>> Ticket URL: = >>>> *3 > >>>>> Apache Bloodhound = >>>>> The Apache Bloodhound (incubating) issue tracker >>>>>=20 >>>>>=20 >=20 --Apple-Mail=_79DA78F8-3E10-4B3E-91E4-AD30F85AB7D7--