incubator-bloodhound-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jure Žitnik <j...@digiverse.si>
Subject Re: #190: Stop the 'More' action on Active Tickets from including the limit on the number of tickets in the custom query (Was: Re: Contributing to Bloodhound)
Date Tue, 25 Sep 2012 07:59:00 GMT
Hi,
this is a patch I'm proposing to fix ticket #190, the More link in 
TicketQueryWidget no longer includes the 'max' (and 'page') parameter.
Cheers,
Jure

Index: bloodhound_dashboard/bhdashboard/widgets/query.py
===================================================================
--- bloodhound_dashboard/bhdashboard/widgets/query.py    (revision 1389733)
+++ bloodhound_dashboard/bhdashboard/widgets/query.py    (working copy)
@@ -88,6 +88,7 @@
                          args[k] = v[0]
                  except TypeError:
                      pass
+            more_link_href = req.href('query', args)
              args.update({'page' : page, 'max': maxrows})

              qrymdl = self.env[QueryModule]
@@ -129,7 +130,7 @@
                          'data' : data,
                          'ctxtnav' : [
                                  tag.a(_('More'),
- href=query.get_href(req.href))],
+                                    href=more_link_href)],
                          'altlinks' : fakereq.chrome.get('links', 
{}).get('alternate')
                      }, \
                      qryctx



On 9/18/12 2:46 AM, Olemis Lang wrote:
> +1 for Gary suggestion
>
> If you need any help to get started please don't hesitate and ask
> ;)
>
> On 9/17/12, Gary Martin <gary.martin@wandisco.com> wrote:
>> Hi Jure,
>>
>> Great to hear from you! As I have just been looking at tickets, I also
>> spotted this one: https://issues.apache.org/bloodhound/ticket/190
>>
>>      #190: Stop the 'More' action on Active Tickets from including the limit
>> on the
>>      number of tickets in the custom query
>>
>>      Used to be in #187:
>>         The query behind the 'More' button on Active Tickets (and I assume on
>> My
>>         Tickets) includes &max=10 to limit the number of tickets shown per
>> page to
>>         10. I believe this should be higher: ~&max=50 for example. That's
>> because
>>         the user is specifically on that page to look for more than the
>> number of
>>         tickets shown on the Dashboard page anyway.
>>
>>      Essentially this is saying that any limit specified for the queries on
>> the
>>      dashboard should not propagate to the "More" query.
>>
>> It is in a very similar area to the one I just mentioned for Peter and,
>> in fact, was at one point mentioned in the same ticket.
>>
>> It also looks like it should be pretty simple and will hopefully let you
>> see the genshi templating language.
>>
>> Cheers,
>>       Gary
>>
>> On 09/17/2012 01:23 PM, Jure Žitnik wrote:
>>> Hi everyone,
>>> I would like to start contributing to the Bloodhound project. I'm
>>> currently digging through the source code. As I think the best way of
>>> getting familiar with the code is by getting my hands dirty, I'd
>>> appreciate if someone could point me to a (beginner) task I could pick
>>> up...
>>> Best regards,
>>> Jure
>>>
>>
>


-- 
Jure Žitnik
email: jure@digiverse.si
skype: jzitnik
mobile: +386 41 378 597

Digiverse d.o.o.
Dolenjska cesta 318
1291 Škofljica
www.digiverse.si


Mime
View raw message