incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #433: Add product / global prefix in label for external wiki handlers - after #390
Date Thu, 07 Mar 2013 21:36:47 GMT
#433: Add product / global prefix in label for external wiki handlers - after
#390
---------------------------+--------------------------------------
  Reporter:  olemis        |      Owner:  nobody
      Type:  enhancement   |     Status:  new
  Priority:  minor         |  Milestone:
 Component:  multiproduct  |    Version:
Resolution:                |   Keywords:  product global TracLinks
---------------------------+--------------------------------------

Comment (by olemis):

 Two more sophisticated inconsistencies that have been detected after
 comment:14:ticket:390

 Firstly , `[product:PREFIX:trac-2041 Trac #2041]` will be expanded to `<a
 class="missing product">trac-2041</a>` instead of `<a class="missing
 product">Trac #2041</a>` .

 Secondly , the following expressions

 {{{
 product:PREFIX:#1-⁵,42
 product:PREFIX:#1,³,5,7
 }}}

 ... are expanded like this ...

 {{{
 #!xml

 <a class="new ticket" href="%(path_prefix)s/ticket/1"
 title="%(link_title_prefix)sThis is the summary (new)">#1</a>
 <a class="new ticket" href="%(path_prefix)s/ticket/1"
 title="%(link_title_prefix)sThis is the summary (new)">#1</a>
 }}}

 rather than what would be «expected» considering non-prefixed form

 {{{
 #!xml
 <a class="new ticket" href="%(path_prefix)s/ticket/1"
 title="%(link_title_prefix)sThis is the summary (new)">#1</a>-⁵,42
 <a class="new ticket" href="%(path_prefix)s/ticket/1"
 title="%(link_title_prefix)sThis is the summary (new)">#1</a>,³,5,7
 }}}

 JFTR , the reason for this to happen is that the product: prefix makes the
 TracLinks resolver to match greedy until the end (outermost match) whereas
 the inner ticket shortcut stops after `#1`. Remaining characters are lost.
 In the short we'll survive doing things this way ... especially because it
 is possible to get the previous output by inserting quotes to explicitly
 delimit the start and end of ticket link e.g.

 {{{
 product:"PREFIX:#1"-⁵,42
 product:"PREFIX:#1",³,5,7
 }}}

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/433#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message