incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #390: Product wiki syntax
Date Thu, 07 Mar 2013 21:19:39 GMT
#390: Product wiki syntax
-------------------------+-------------------------------------------------
  Reporter:  olemis      |      Owner:  olemis
      Type:  task        |     Status:  accepted
  Priority:  major       |  Milestone:
 Component:              |    Version:
  multiproduct           |   Keywords:  product resource wiki syntax
Resolution:              |  TracLinks
-------------------------+-------------------------------------------------

Comment (by olemis):

 Replying to [comment:6 olemis]:
 > I'm proposing to new patches for #390 .

 Latest submissions are rebased against r1453952

 > Observations :
 >
 >   - If you take a look at [http://pastebin.com/PSzv0eZd this test
 report]
 >     including a relevant subset of the test suite affected by these
 modifications
 >     then you might notice that the only failed test cases are
 >     * those for `TicketQuery` , maybe related to #434
 >       (@jure @mathevzb could you please take a look ?)

 still failing :'(

 >     * ... and a few more to check for a bizarre case (unicode chars ,
 etc ...)
 >       I'll deal with this one .

 The issue with unicode digits is solved after applying
 [attachment:t390_r1453952_product_wikisyntax_nomatch.diff this patch] .
 [attachment:t390_r1453952_product_ticket_jira.diff Another one] adds
 concise JIRA ticket syntax . Finally there is a
 [attachment:t390_r1453952_product_wikisyntax_compact.diff third one]
 implementing compact product syntax by considering `~` as delimiter
 character. In order to use another char just set
 `MultiproductSystem.short_syntax_delimiter = THECHAR` and run the test
 suite to see if everything is ok .

 ;)

 Patches have to be applied in the following order .

 {{{
 #!sh

 $ hg qapplied
 t390/t390_r1453952_product_wikisyntax.diff
 t390/t390_r1453952_product_ticket_jira.diff
 t390/t390_r1453952_product_wikisyntax_nomatch.diff
 t390/t390_r1453952_product_wikisyntax_compact.diff

 $ hg log -r qparent --template="[r{svnrev}] {desc}\n"
 [r1453952] LRU & LFU cache implementations added, appropriate files
 (license, notice,...) updated appropriately

 }}}

 Decisions have to be made though ; [http://pastebin.com/upWERtuX
 2013-03-06 test report] hints us of the fact that the introduction of JIRA
 compact ticket syntax will trigger a regression due to the clash with
 already supported TracLinks expressions e.g.

 {{{

 $ python setup.py test -m tests

 [...]

 ======================================================================
 FAIL: Test Another arbitrary protocol Link
 ----------------------------------------------------------------------
 Traceback (most recent call last):
   File "/path/to/bloodhound/trac/trac/wiki/tests/formatter.py", line 209,
 in test
     % (msg, self.file, self.line, self.title, formatter.flavor))
 AssertionError: u'<p>\n<a class="ext-link"
 href="svn+ssh://secureserver.org"><span class="icon"> [truncated]... !=
 u'<p>\n<a class="ext-link" href="svn+ssh://secureserver.org"><span
 class="icon"> [truncated]...
   <p>
   <a class="ext-link" href="svn+ssh://secureserver.org"><span
 class="icon"></span>svn+ssh://secureserver.org</a>
   <a class="ext-link" href="svn+ssh://secureserver.org"><span
 class="icon"></span>SVN link</a>
 - <a class="ext-link" href="rfc-2396.compatible://link"><span
 class="icon"></span>rfc-2396.compatible://link</a>
 + <a class="missing product">rfc-2396</a>.compatible://link
   <a class="ext-link" href="rfc-2396.compatible://link"><span
 class="icon"></span>RFC 2396</a>
 - <a class="ext-link" href="rfc-2396+under_score://link"><span
 class="icon"></span>rfc-2396+under_score://link</a>
 + <a class="missing product">rfc-2396</a>+under_score://link
   <a class="ext-link" href="rfc-2396+under_score://link"><span
 class="icon"></span>underscore</a>
   unsafe://scheme is not rendered
   </p>


 /path/to/bloodhound/trac/trac/wiki/tests/wiki-tests.txt:474: "Another
 arbitrary protocol Link" (default flavor)

 ----------------------------------------------------------------------
 }}}

 That a test case found in Trac core , not added in the patches mentioned
 above . Target wiki test and expected output pasted below

 {{{
 #!xml

 ============================== Another arbitrary protocol Link
 svn+ssh://secureserver.org
 [svn+ssh://secureserver.org SVN link]
 rfc-2396.compatible://link
 [rfc-2396.compatible://link RFC 2396]
 rfc-2396+under_score://link
 [rfc-2396+under_score://link underscore]
 unsafe://scheme is not rendered
 ------------------------------
 <p>
 <a class="ext-link" href="svn+ssh://secureserver.org"><span
 class="icon"></span>svn+ssh://secureserver.org</a>
 <a class="ext-link" href="svn+ssh://secureserver.org"><span
 class="icon"></span>SVN link</a>
 <a class="ext-link" href="rfc-2396.compatible://link"><span
 class="icon"></span>rfc-2396.compatible://link</a>
 <a class="ext-link" href="rfc-2396.compatible://link"><span
 class="icon"></span>RFC 2396</a>
 <a class="ext-link" href="rfc-2396+under_score://link"><span
 class="icon"></span>rfc-2396+under_score://link</a>
 <a class="ext-link" href="rfc-2396+under_score://link"><span
 class="icon"></span>underscore</a>
 unsafe://scheme is not rendered
 </p>
 ------------------------------

 }}}

 What shall we do ?

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/390#comment:14>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message