Mailing-List: contact bloodhound-commits-help@incubator.apache.org;
 run by ezmlm
Precedence: bulk
Reply-To: bloodhound-dev@incubator.apache.org
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: "Apache Bloodhound" <bloodhound-dev@incubator.apache.org>
Cc: bloodhound-commits@incubator.apache.org
Auto-Submitted: auto-generated
Date: Fri, 08 Feb 2013 18:22:27 -0000
Reply-To: bloodhound-dev@incubator.apache.org
Subject: Re: [Apache Bloodhound] #355: Run Trac test suite against product
 environments - after #115 #288
Message-ID: <070.2c36f752558f9eaa4c17926d5243b08f@incubator.apache.org>
References: <055.f95383b8b60cd0fe9638b5798e9b53e7@incubator.apache.org>
In-Reply-To: <055.f95383b8b60cd0fe9638b5798e9b53e7@incubator.apache.org>

#355: Run Trac test suite against product environments - after #115 #288
---------------------------+------------------------------------
  Reporter:  olemis        |      Owner:  olemis
      Type:  task          |     Status:  accepted
  Priority:  major         |  Milestone:
 Component:  multiproduct  |    Version:
Resolution:                |   Keywords:  environment testing QA
---------------------------+------------------------------------

Comment (by olemis):

 Two new patches attached .
 [attachment:t355_r1442601_trac_test_env_cmp_enabled.diff The first one]
 improves previous algorithm to determine whether a component is enabled /
 disabled in product scope . In there I also fixed a major problem with
 product configuration and added a test case to track regressions .

 In the process I also noticed that `table.attribute` expressions are not
 actually working in `bhdashboard.model.ModelBase` and all other model
 subclasses . Nevertheless , in code I found

 {{{
 #!py

     def __setattr__(self, name, value):
         """Overridden to allow table.field = value style field setting."""
         # ------8<------ Code omitted ------8<------

 }}}

 @gjm : could you please take a look at this ?

 The [attachment:t355_r1442601_trac_test_ticket_conversion.diff second
 patch] translates Trac's test cases for ticket MIME conversions (csv, tsv,
 rss, ... and alike).

 As a consequence it also removes leading and trailing whitespaces inserted
 by `pkg_resources` after loading TRAC_VERSION file in vendor branch. BTW
 there is something weird with TRAC_VERSION file in trunk . [ticket:153
 Once upon a time] we agreed to include in there the exact revision number
 (i.e. svn changeset ID) of Trac incorporated in vendor branch. Now I
 notice that it is set to `1.0` . Shall we append it in there ?

 Full patch history can be found in [https://bitbucket.org/olemis
 /bloodhound-mq/commits/branch/t355_trac_test_suite branch
 t355_trac_test_suite in olemis/bloodhound-mq patch queue @ Bitbucket] . I
 pasted a summary below .

 {{{
 #!sh

 $ hg log --mq -l 11 | grep "^summary"

 summary:     BH Multiproduct #355 : Correct product name and TRAC_VERSION
 inserted in ticket RSS feed
 summary:     BH Multiproduct #355 : Test cases for ticket MIME conversions
 almost ready
 summary:     BH Multiproduct #355 :
 ProductEnvironment.is_component_enabled logic fully tested
 summary:     BH Multiproduct #355 : Bug fixed : Overwrite existing product
 config option
 summary:     BH Multiproduct #355 : Enhanced algorithm to determine
 whether component is disabled. Test case for environment configuration
 inheritance
 summary:     BH Multiproduct #355 : Oops ! Refresh ticket model patch to
 move some changes onto MIME conversions patch
 summary:     BH Multiproduct #355 : Towards a more reliable enabling
 algorithm in product context
 summary:     BH Multiproduct #355 : Rewrite Trac's test cases for ticket
 models. Load test data after MP upgrade
 summary:     BH Multiproduct #355 : Disable TicketModule on MP upgrade.
 Rewrite tests for ticket conversions ... (errors=1)
 summary:     BH Multiproduct #355 : Checking for custom fields isolation
 across product boundaries (against r1442575) ... [ok]
 summary:     BH Multiproduct #355 : Added test cases about product
 boundaries regarding ticket API

 }}}

 PS: I'm working on test cases for ticket models now .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/355#comment:20>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker