incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #410: Clicking on the Apache Bloodhound image in the header should direct to WikiStart
Date Thu, 21 Feb 2013 07:32:04 GMT
#410: Clicking on the Apache Bloodhound image in the header should direct to
WikiStart
--------------------------+-----------------------
  Reporter:  rjollos      |      Owner:  rjollos
      Type:  enhancement  |     Status:  new
  Priority:  trivial      |  Milestone:  Release 5
 Component:  ui design    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by rjollos):

 Replying to [comment:1 olemis]:
 > PS: AFAICR there was an option in TracIni for header link.

 Good idea. I agree that it seems like the best move here would be to just
 set the default for a Bloodhound installation to direct to the `base_url`
 and let `default_handler` do it's work. This patch will accomplish that:
 {{{
 #!patch
 Index: bloodhound_theme/bhtheme/templates/bloodhound_theme.html
 ===================================================================
 --- bloodhound_theme/bhtheme/templates/bloodhound_theme.html    (revision
 1448441)
 +++ bloodhound_theme/bhtheme/templates/bloodhound_theme.html    (working
 copy)
 @@ -65,8 +65,10 @@
            <!--! logo -->
            <div id="logo" class="span4">
              <p>
 -              <img src="${chrome.logo.src or
 href.chrome('theme/img/bh_logo.png')}"
 -                  alt="Bloodhound Logo" />
 +              <a href="${chrome.logo.link or href()}">
 +                <img src="${chrome.logo.src or
 href.chrome('theme/img/bh_logo.png')}"
 +                     alt="Bloodhound Logo" />
 +              </a>
              </p>
            </div>
            <!--! top menu (login, logout...) -->
 }}}

 Is it worth the extra code to allow the user to specify a URL relative to
 `base_url`? With the patch, the user can specify an absolute URL, but with
 some additional code, we could allow the user to specify, for example,
 `/dashboard`, to have the image direct to the Dashboard regardless of what
 the `default_handler` is.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/410#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message