incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #376: Move upload form in plugin admin panel to the top
Date Mon, 11 Feb 2013 17:08:20 GMT
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
  Reporter:  olemis       |      Owner:  rjollos
      Type:  enhancement  |     Status:  accepted
  Priority:  major        |  Milestone:
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  admin plugins
--------------------------+---------------------------

Comment (by rjollos):

 Replying to [comment:6 olemis]:
 > > The Admin Components and other panels have the "old style" layout with
 the ''Add'' forms on the right.

 Okay, but I'll do that work in another ticket.

 > `.icon-file` element is not consistent with the usage in other contexts
 , so IMO should be removed . OTOH `icon-upload` is actually right and
 afaicr even included in the initial solution ... but it was removed when
 the corresponding patch was committed . In general , except in a few
 notable exceptions (e.g. when iconifying ticket scroll spy elements in
 response to screen size limitations) , all icons I've been including in
 buttons have been dropped .

 I've removed both uses of icons. I'd like to make use of them, but I'll
 save changes like that for another ticket when they can be discussed in
 detail.

 > Firstly remove `.well` panel and only render the `.alert` on error .
 >
 > Secondly there is a template named `widget_alert.html` , please use it
 as it is aimed at controlling in a single place the changes in alerts look
 and feel (i.e. updates in the template will propagate right away to all
 other instances) .

 I've made both of those changes in r1444869. I'm reassigning the ticket to
 you. Please close if you find all of the changes satisfactory.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:13>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message