incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #376: Move upload form in plugin admin panel to the top
Date Sun, 10 Feb 2013 01:21:35 GMT
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
  Reporter:  olemis       |      Owner:  rjollos
      Type:  enhancement  |     Status:  accepted
  Priority:  major        |  Milestone:
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  admin plugins
--------------------------+---------------------------

Comment (by olemis):

 Replying to [comment:4 rjollos]:
 > [trac 11164] is where the change was made in Trac.

 I c ...

 > I noticed we have some inconsistencies in Bloodhound at the moment.

 That's what they lookd like atm ... once upon a time
 ;)

 > The Admin Components and other panels have the "old style" layout with
 the ''Add'' forms on the right.

 Please change it and move to the top .

 > The Admin Milestones panel has the vertical layout with the ''Manage
 Milestone'' table above the ''Add Milestone'' form.
 >

 Yes , because space was limited since the beginning . That's why it used
 that layout in first place . The same is proposed in #248

 > Here are some screen captures of changes to the Admin Plugins panel.
 >
 [...]

 My feedback below

 > [attachment:ManagePluginNormal.png]
 >

 `.icon-file` element is not consistent with the usage in other contexts ,
 so IMO should be removed . OTOH `icon-upload` is actually right and afaicr
 even included in the initial solution ... but it was removed when the
 corresponding patch was committed . In general , except in a few notable
 exceptions (e.g. when iconifying ticket scroll spy elements in response to
 screen size limitations) , all icons I've been including in buttons have
 been dropped .

 >
 > [attachment:ManagePluginsInsufficientPermissions.png]

 Firstly remove `.well` panel and only render the `.alert` on error .

 Secondly there is a template named `widget_alert.html` , please use it as
 it is aimed at controlling in a single place the changes in alerts look
 and feel (i.e. updates in the template will propagate right away to all
 other instances) .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message