incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #248: Improve layout of repository admin panel - after #15
Date Sun, 10 Feb 2013 16:40:54 GMT
#248: Improve layout of repository admin panel - after #15
--------------------------+---------------------------------
  Reporter:  olemis       |      Owner:  olemis
      Type:  enhancement  |     Status:  review
  Priority:  minor        |  Milestone:  Release 5
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  admin vcs bootstrap
--------------------------+---------------------------------

Comment (by olemis):

 Replying to [comment:5 rjollos]:
 > (In [1444499])
 >
 > Refs #248: Modified Repository Admin panel to use a horizontal layout.
 Patch by Olemis.
 >
 > The following changes were applied on top of the patch.
 >  * Removed the `full-x` class from the **Directory** `th` in order to
 get a layout like that shown in comment:2. With the class in place, the
 **Name** column is too narrow, even when the additional space is not
 needed for **Directory**. See example below.

 Directory column will consume most of the horizontal size , that's why it
 included `full-x` so that it would be able to occupy most of the width .

 >  * Used the `help-inline` class for the help text in the `type_field`
 function.

 cool

 >  * Applied a change similar to [trac 11164#file7] so that the
 `type_field` and `alias_field` functions can support both horizontal and
 vertical layouts. Both functions now have an `inline` argument.
 >

 good

 > [attachment:NameColumnTooNarrow.png]
 >

 The issue with name column is that you have to insert `whitespace :
 nowrap` so that inner text will not wrap across whitespace boundaries .

 > Olemis, I'm reassigning the ticket to you for review.

 Ok . I'll do that in a while ...

 > Please close the ticket if you find all of the changes satisfactory.

 ... and let you know

 > We can leave you as the owner of the ticket since you did most of the
 work here.

 Nevermind ... just find some time to search for all the tickets I've
 worked with before (plenty of them btw) and notice that most of them do
 not . Mainly because gjm or jdreimann had the last word by reviewing and
 committing . So if you commit and improve these changes then feel free to
 assign owner at will . I will not complain about that .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/248#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message