incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #336: bhdashboard.model.ModelBase insert method fails if no unique fields specified
Date Tue, 19 Feb 2013 03:15:08 GMT
#336: bhdashboard.model.ModelBase insert method fails if no unique fields
specified
---------------------------+------------------------------
  Reporter:  franco        |      Owner:  nobody
      Type:  defect        |     Status:  new
  Priority:  critical      |  Milestone:  Release 5
 Component:  multiproduct  |    Version:  0.3.0
Resolution:                |   Keywords:  model sql insert
---------------------------+------------------------------

Comment (by gjm):

 Replying to [comment:3 olemis]:
 > IMO that's not enough due to the fact that `WHERE` clause will check for
 the combination of unique fields . IOW for UNIQUE checks the logic op
 should be `OR` instead of `AND` .
 >
 > CMIIW

 Well, the point of the change is that we get failure if there are no
 unique fields defined. As such, we only need to run the code here if
 {{{self._meta['unique_fields']}}} is not empty.

 Beyond that, we might want to distinguish between unique individually and
 fields that are unique together but that can be in a new ticket.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/336#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message