incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #384: Control overflow of ticket comment edit box - after #146
Date Fri, 22 Feb 2013 06:31:01 GMT
#384: Control overflow of ticket comment edit box - after #146
------------------------+-----------------------------------------------
  Reporter:  olemis     |      Owner:  rjollos
      Type:  defect     |     Status:  accepted
  Priority:  minor      |  Milestone:  Release 5
 Component:  ui design  |    Version:  0.4.0
Resolution:             |   Keywords:  ticket comment inplace regression
------------------------+-----------------------------------------------
Changes (by rjollos):

 * priority:  major => minor
 * milestone:   => Release 5


Comment:

 Replying to [comment:8 jdreimann]:
 > Yes, I believe the Admin panels should be consistent with other parts of
 the UI.

 Okay, I'll handle that change in #353, and I've also opened up a ticket
 suggesting a change in trac:#11076 (won't affect us though because it's
 obviously isolated to the templates, but it's an easy change to make there
 as well, and sometimes we get interesting feedback even on the most minor
 issues).

 > I also believe that Cancel and other secondary actions should be
 displayed with the .btn-link class to look like links. that makes the
 differentiation clearer between common, safe actions (buttons) and
 potentially unsafe, rarer actions (archive, delete, cancel).
 > With that .btn-link class it will necessarily look separated.

 I like the idea of separation. The `btn-link` styling doesn't look quite
 right, but maybe it'll grow on me. Anyway, I proceeded with the suggested
 change.

 Here is a screen capture of the modified buttons:

 [[Image(Buttons2.png)]]

 ----

 (In [1448910])

 Refs #384: Modify ticket comment editor submit buttons to Bootstrap
 styling.

 ----

 Olemis: I wasn't able to reproduce the exact issue shown in the screen
 capture you posted here. Therefore, I'll ask you to test out the latest
 changes, and please close the ticket if you find that all is well.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/384#comment:10>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message