Return-Path: X-Original-To: apmail-incubator-bloodhound-commits-archive@minotaur.apache.org Delivered-To: apmail-incubator-bloodhound-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0B819E0B1 for ; Mon, 7 Jan 2013 16:36:26 +0000 (UTC) Received: (qmail 28748 invoked by uid 500); 7 Jan 2013 16:36:26 -0000 Delivered-To: apmail-incubator-bloodhound-commits-archive@incubator.apache.org Received: (qmail 28717 invoked by uid 500); 7 Jan 2013 16:36:25 -0000 Mailing-List: contact bloodhound-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: bloodhound-dev@incubator.apache.org Delivered-To: mailing list bloodhound-commits@incubator.apache.org Received: (qmail 28702 invoked by uid 99); 7 Jan 2013 16:36:25 -0000 Received: from bloodhound-vm.apache.org (HELO bloodhound-vm) (140.211.11.32) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Jan 2013 16:36:25 +0000 Received: from bloodhound-vm.apache.org (localhost [127.0.0.1]) by bloodhound-vm (Postfix) with ESMTP id 505128006A; Mon, 7 Jan 2013 16:36:25 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit From: "Apache Bloodhound" X-Trac-Version: 1.0 Cc: bloodhound-commits@incubator.apache.org Auto-Submitted: auto-generated X-Mailer: Trac 1.0, by Edgewall Software X-Trac-Project: Apache Bloodhound Date: Mon, 07 Jan 2013 16:36:24 -0000 Reply-To: bloodhound-dev@incubator.apache.org X-URL: https://issues.apache.org/bloodhound/ Subject: Re: [Apache Bloodhound] #333: Rely on ModelBase._get_schema to populate MultiProductSystem.SCHEMA - after #314 X-Trac-Ticket-URL: https://issues.apache.org/bloodhound/ticket/333#comment:4 Message-ID: <070.31ecb36c29821fca7151a3fdce5d002b@incubator.apache.org> References: <055.2fdc55aaad788488591d8ac6fddb8d79@incubator.apache.org> X-Trac-Ticket-ID: 333 In-Reply-To: <055.2fdc55aaad788488591d8ac6fddb8d79@incubator.apache.org> #333: Rely on ModelBase._get_schema to populate MultiProductSystem.SCHEMA - after #314 ---------------------------+----------------------- Reporter: olemis | Owner: gjm Type: enhancement | Status: closed Priority: major | Milestone: Release 4 Component: multiproduct | Version: Resolution: fixed | Keywords: database ---------------------------+----------------------- Changes (by gjm): * status: review => closed * resolution: => fixed Comment: I made a few changes to make it all a bit more compact and add in a docstring that I forgot but otherwise the ideas are fine. r1429859 fixes the tests to run from running the file directly r1429875 adds the ability to specify auto increment fields in schema generated from model metadata r1429877 adds the auto increment field specification to the {{{ProductResourceMap}}} model r1429886 saves the {{{MultiProductSystem}}} from repeating the specification of the schema when it is already defined within the models and extracted with the {{{_get_schema}}} method -- Ticket URL: Apache Bloodhound The Apache Bloodhound (incubating) issue tracker