incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #330: Lazy evaluation of req.chrome
Date Thu, 24 Jan 2013 20:36:36 GMT
#330: Lazy evaluation of req.chrome
--------------------------+--------------------
  Reporter:  peter        |      Owner:  nobody
      Type:  enhancement  |     Status:  closed
  Priority:  minor        |  Milestone:
 Component:  dashboard    |    Version:
Resolution:  fixed        |   Keywords:
--------------------------+--------------------

Comment (by rjollos):

 Replying to [comment:9 olemis]:
 > > I invoked the !TracError by replacing `data` with `None` in
 `trac.wiki.web_ui._render_view`. I wanted to force an exception when the
 template was rendered.
 >
 > That's not the kind of errors we are tracking in this ticket . Indeed ,
 its goal is not to instantiate `req.chrome` **IF** there is no template
 processing involved .

 Your comment was ''Otherwise error pages seem not to get the proper
 styling info ... First we should check whether error pages will be broken
 after r1437967.'', therefore I thought that as a side issue we needed to
 look at whether !TracError pages were rendering correctly. This seemed
 relevant since I had noticed recently that they were not rendering
 correctly.

 > AFAICT if there's an error rendering a Genshi template then you'll get a
 plain-text error message.

 My test case results in a genshi template rendering error, and in that
 case my screen capture shows that the !TracError page is rendered.
 However, in other cases I only see a plain-text error message. I don't
 understand what conditions lead to the different views.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/330#comment:10>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message