incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #330: Lazy evaluation of req.chrome
Date Thu, 24 Jan 2013 20:23:04 GMT
#330: Lazy evaluation of req.chrome
--------------------------+--------------------
  Reporter:  peter        |      Owner:  nobody
      Type:  enhancement  |     Status:  closed
  Priority:  minor        |  Milestone:
 Component:  dashboard    |    Version:
Resolution:  fixed        |   Keywords:
--------------------------+--------------------

Comment (by olemis):

 Replying to [comment:8 rjollos]:
 > Replying to [comment:7 olemis]:
 > > Notice that another check for `sys.exc_info` is needed (see [http
 ://trac-hacks.org/changeset/12540 this fix for ThemeEnginePlugin] for
 further details) . Otherwise error pages seem not to get the proper
 styling info .
 > >
 > > I was tempted to reopen this ticket , but I didn't . First we should
 check whether error pages will be broken after r1437967 .
 >
 > I had noticed the other day that !TracError pages weren't rendering
 correctly. I tested again today in an environment created last week, and
 saw that the !TracError page was rendering correctly, but the theme had
 gone away. I then created a new environment in order to get the latest
 version of [trachacks:ThemeEnginePlugin] with Olemis' fixes, and now I see
 something that looks nice:
 >
 [...]

 yes , that's correct . I noticed the issue recently .

 > I invoked the !TracError by replacing `data` with `None` in
 `trac.wiki.web_ui._render_view`. I wanted to force an exception when the
 template was rendered.

 That's not the kind of errors we are tracking in this ticket . Indeed ,
 its goal is not to instantiate `req.chrome` **IF** there is no template
 processing involved .

 {{{
 #!div class="well"

 {{{
 #!span class="label label-info"

 OT
 }}}
 AFAICT if there's an error rendering a Genshi template then you'll get a
 plain-text error message . I guess that happens because the failure took
 place at a lower layer (i.e. ''Genshi'' rendering engine)
 }}}

 > Are there other ways good ways to test this?
 >

 I usually just go to /ticket/whatever_that_fails ... I do not know if
 that's good enough though .

 [...]

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/330#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message