incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #330: Lazy evaluation of req.chrome
Date Wed, 02 Jan 2013 22:14:34 GMT
#330: Lazy evaluation of req.chrome
--------------------------+--------------------
  Reporter:  peter        |      Owner:  nobody
      Type:  enhancement  |     Status:  new
  Priority:  minor        |  Milestone:
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+--------------------

Comment (by olemis):

 Replying to [ticket:330 peter]:
 > For optimal performance req.chrome should be evaluated only if
 necessary.
 > This currently violated on multiple places in request handlers, filters
 and mainly by trachacks:TracThemeEngine plugin.
 >

 Could you please mention where is it exactly that
 trachacks:ThemeEnginePlugin violates lazy instantiation of `req.chrome` ?

 [...]
 > However there has been no investigation on trachacks:TracThemeEngine
 yet. Until this is fixed there is no benefits in fixing BH code at all.

 I'm the maintainer of that plugin . I've not noticed something like that ,
 so I ask : What's wrong exactly ?

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/330#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message