incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #330: Lazy evaluation of req.chrome
Date Sun, 27 Jan 2013 16:06:25 GMT
#330: Lazy evaluation of req.chrome
--------------------------+--------------------
  Reporter:  peter        |      Owner:  nobody
      Type:  enhancement  |     Status:  closed
  Priority:  minor        |  Milestone:
 Component:  dashboard    |    Version:
Resolution:  fixed        |   Keywords:
--------------------------+--------------------

Comment (by olemis):

 Replying to [comment:12 andrej]:
 > I can see the similar behavior when rendering an error page on local env
 (rev 1439061).  The error occurs when an exception is trigged during
 request dispatching by handler.
 >
 [...]
 >
 > As far as I understand the code, the problem is in
 bloodhound_theme/bhtheme/theme.py, line 217
 >
 [...]

 So yes , this confirms my previous suspicion .

 >
 > In case of an exception during request processing, the
 post_process_request method is called with all None parameters, so method
 returns before {{{req.chrome['labels']}}} is filled.
 >

 That's right . That's what I was talking about .

 > I think we need another way to figure out when we can skip theme post
 processing. So far my suggestion is:

 Did you read [comment:7 my previous comment] ? In there I mention how I
 fixed exactly the same issue , but for trachacks:ThemeEnginePlugin .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/330#comment:13>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message