incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #288: Create prototype for legacy database schema proxy
Date Fri, 25 Jan 2013 18:05:32 GMT
#288: Create prototype for legacy database schema proxy
---------------------------+-----------------------------------
  Reporter:  jure          |      Owner:  jure
      Type:  enhancement   |     Status:  new
  Priority:  major         |  Milestone:
 Component:  multiproduct  |    Version:
Resolution:                |   Keywords:  bep-0003 multiproduct
---------------------------+-----------------------------------

Comment (by olemis):

 Replying to [comment:15 jure]:
 > Replying to [comment:14 olemis]:
 [...]
 > >
 > > ... but ... there still some issues identified while running test
 cases for dafault permissions store . The most critical being
 > >
 > > [...]
 > >
 > > @jure : could you please take a look ?
 > >
 >
 > Yes, that's what I'm looking into atm, the problem are INSERTs w/o
 specifying column names as we get column mismatches. I plan to have a
 patch for this later today.
 >

 I see it's already there . I'll take a look once the fix mentioned below
 will be added .

 > > Anyway , I'll continue working on #355 . By the time this will be
 fixed I'll come back to this once again .
 >
 > Great.

 :)

 > One note though, the permission test should include product column value
 when inserting into global environment. But you might wait with that till
 after my patch...

 IMO it's quite important to be consistent with the previous approach (i.e.
 no explicit reference to products in SQL queries ). All this should be
 encapsulated e.g. the proxy has to detect whether a product is not set in
 context and still translate the query considering `product = NULL` (
 `product = ''` ? ) . All instances of `product = NULL` will refer to
 resources in the global environment . That would be enough to keep the
 interface exactly the same as before .

 I don't know how much complicated this will be for you to add this feature
 , but IMO it's a **MUST** . Is it feasible up to this point ?

 Everything **must** be just like before for both product envs and global
 env . That's exactly the point .
 ''';)'''

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/288#comment:17>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message