incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #286: Project description text on Basic Settings has leading whitespace
Date Wed, 05 Dec 2012 22:38:12 GMT
#286: Project description text on Basic Settings has leading whitespace
------------------------+-----------------------
  Reporter:  rjollos    |      Owner:  rjollos
      Type:  defect     |     Status:  accepted
  Priority:  trivial    |  Milestone:  Release 4
 Component:  ui design  |    Version:
Resolution:             |   Keywords:  settings
------------------------+-----------------------
Changes (by rjollos):

 * status:  new => accepted


Old description:

> [[Image(ProjectSettings-Description.png)]]
>
> This can be addressed with the following patch:
> {{{
> #!patch
> Index: bloodhound_theme/bhtheme/templates/bh_admin_basics.html
> ===================================================================
> --- bloodhound_theme/bhtheme/templates/bh_admin_basics.html     (revision
> 1417310)
> +++ bloodhound_theme/bhtheme/templates/bh_admin_basics.html     (working
> copy)
> @@ -49,8 +49,8 @@
>          <div class="control-group">
>            <label class="control-label" for="descr">Description:</label>
>            <div class="controls">
> -            <textarea id="descr" name="descr" class="trac-resizable"
> rows="3" cols="50">
> -                      ${project.descr}</textarea>
> +            <textarea id="descr" name="descr" class="trac-resizable"
> +                      rows="3" cols="50">${project.descr}</textarea>
>            </div>
>          </div>
>          <div class="control-group">
> }}}
>
> In the Trac core, they deal with the issue by not indenting the line:
> {{{
> #!python
>             <textarea name="descr" class="trac-resizable" rows="3"
> cols="50">
> ${project.descr}</textarea>
> }}}
>
> I tend to think the above patch is better stylistically, but I'll wait
> for feedback from others before committing.

New description:

 [[Image(ProjectSettings-Description.png)]]

 This can be addressed with the following patch:
 {{{
 #!diff
 Index: bloodhound_theme/bhtheme/templates/bh_admin_basics.html
 ===================================================================
 --- bloodhound_theme/bhtheme/templates/bh_admin_basics.html     (revision
 1417310)
 +++ bloodhound_theme/bhtheme/templates/bh_admin_basics.html     (working
 copy)
 @@ -49,8 +49,8 @@
          <div class="control-group">
            <label class="control-label" for="descr">Description:</label>
            <div class="controls">
 -            <textarea id="descr" name="descr" class="trac-resizable"
 rows="3" cols="50">
 -                      ${project.descr}</textarea>
 +            <textarea id="descr" name="descr" class="trac-resizable"
 +                      rows="3" cols="50">${project.descr}</textarea>
            </div>
          </div>
          <div class="control-group">
 }}}

 In the Trac core, they deal with the issue by not indenting the line:
 {{{
 #!python
             <textarea name="descr" class="trac-resizable" rows="3"
 cols="50">
 ${project.descr}</textarea>
 }}}

 I tend to think the above patch is better stylistically, but I'll wait for
 feedback from others before committing.

--

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/286#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message