incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #312: Configure ticket fields in create ticket shortcut
Date Wed, 19 Dec 2012 14:53:36 GMT
#312: Configure ticket fields in create ticket shortcut
--------------------------+------------------------
  Reporter:  olemis       |      Owner:  gjm
      Type:  enhancement  |     Status:  review
  Priority:  major        |  Milestone:
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  ticket qct
--------------------------+------------------------

Comment (by olemis):

 Replying to [comment:3 rjollos]:
 > This is a redundant comment with what I said in #168, but I favor this
 change.

 what comment exactly ?

 > I'd suggest an option that is more descriptive than `shorcut_fields`
 though. In my original patch for #168,

 Sorry . As it was closed:wontfix I didn't follow . Now I see that some
 things like milestone permissions are relevant here too . Could you please
 take a look and either update patch or provide another on top ?

 > I named it `quick_create_fields`. I think `quick_ticket_fields` is
 better though.
 >

 +1 that's a better name , please change it

 > Olemis: I think you may have intended to point to
 [/attachment/ticket/234/t234_r1423108_qct_desc_v2.diff this patch].
 >

 well , afaics that patch only adds description box . This ticket is about
 the controls below which is implemented in ...link_n_fields... patch .
 cmiiw

 > If we allow this degree of configuration, we may want to go a step
 further remove the restriction on select fields eventually. What is the
 motivation for imposing that restriction at this time?

 Currently the template only renders select controls . I was just trying to
 ensure that such logic would not be applied to e.g. a boolean field ;) .
 I'm not against adding further field types in there , thereby complicating
 template code, if there is a good reason to do so . However IMO that's
 better tackled in a separate ticket . What d'u you think ?

 > We should mention in the doc string for the option that this restriction
 is in place, otherwise users might think it is a bug when they try to add
 a custom text field to the quick ticket form. This should be an easy
 change for the committer to make, no need to refresh the patch.

 +1

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/312#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message