incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #223: Prepare ticket view for responsive layout
Date Wed, 14 Nov 2012 14:27:48 GMT
#223: Prepare ticket view for responsive layout
-------------------------+-------------------------------------------------
  Reporter:  olemis      |      Owner:  olemis
      Type:              |     Status:  needinfo(review)
  enhancement            |  Milestone:  Release 3
  Priority:  major       |    Version:
 Component:  ui design   |   Keywords:  ticket scrollspy inplace bheditable
Resolution:              |
-------------------------+-------------------------------------------------
Changes (by gjm):

 * owner:  gjm => olemis
 * status:  review => needinfo(review)


Comment:

 Although it is a little more verbose, if we want to avoid messing with
 Trac, couldn't we do this:
 {{{
 #!diff
 Index: bhtheme/templates/bloodhound_theme.html
 ===================================================================
 --- bhtheme/templates/bloodhound_theme.html     (revision 1408747)
 +++ bhtheme/templates/bloodhound_theme.html     (working copy)
 @@ -65,7 +65,14 @@
            <py:with vars="meta_items = dict([i.name, i] for i in
 chrome.nav.metanav)">
              <div class="span8">
                <div class="metanav pull-right">
 -                <span id="nav_login">${meta_items.login.label}</span>
 +                <span id="nav_login" py:choose="">
 +                  <py:when test="req.authname and req.authname !=
 'anonymous'">
 +                    <i class="icon-user"/>${req.authname}
 +                  </py:when>
 +                  <py:otherwise>
 +                    <a href="${req.href.login()}">${_("Login")}</a>
 +                  </py:otherwise>
 +                </span>
                  <span py:if="'logout' in meta_items" id="nav_logout">
                    ${meta_items.logout.label}
                  </span>
 }}}

 Also, is this the last of the work described by this ticket?

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/223#comment:14>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message