incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #254: Checking for wrong permission while rendering product description
Date Mon, 05 Nov 2012 07:04:49 GMT
#254: Checking for wrong permission while rendering product description
---------------------------+------------------------------
  Reporter:  olemis        |      Owner:  olemis
      Type:  defect        |     Status:  accepted
  Priority:  major         |  Milestone:  Release 3
 Component:  multiproduct  |    Version:
Resolution:                |   Keywords:  product resource
---------------------------+------------------------------
Changes (by olemis):

 * keywords:   => product resource
 * status:  new => accepted
 * owner:  nobody => olemis
 * milestone:   => Release 3


Old description:

> ,, ... via ''Bloodhound'' quick create ticket dialog,,

New description:

 Products resource manager has been checking so far for `MILESTONE_CREATE`
 permission rather than `PRODUCT_CREATE` while rendering product
 description for missing products.

 ,, ... via ''Bloodhound'' quick create ticket dialog,,

--

Comment:

 This is caused by a typo . The following patch should fix this issue .

 {{{
 #!diff

 --- a/multiproduct/api.py       Mon Nov 05 00:46:16 2012 -0500
 +++ b/multiproduct/api.py       Mon Nov 05 02:01:22 2012 -0500
 @@ -168,7 +168,7 @@
              href = context.href.products(product.prefix)
              if 'PRODUCT_VIEW' in context.perm(product.resource):
                  return tag.a(label, class_='product', href=href + extra)
 -        elif 'MILESTONE_CREATE' in context.perm('product', name):
 +        elif 'PRODUCT_CREATE' in context.perm('product', name):
              return tag.a(label, class_='missing product',
                      href=context.href('products', action='new'),
                      rel='nofollow')

 }}}

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/254#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message