incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #177: Move 'comment:1' and 'reply to' indicators under the time in ticket view
Date Wed, 03 Oct 2012 16:09:43 GMT
#177: Move 'comment:1' and 'reply to' indicators under the time in ticket view
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  major        |  Milestone:  Release 2
 Component:  ui design    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by olemis):

 Replying to [comment:20 gjm]:
 > So, after all that discussion, isn't something like
 [attachment:t177_r1393493_moving_comment_link_and_threading_under_date.diff​
 this patch] more like what Joe meant (applying the relevant parts of the
 patches from olemis to this ticket with a small rearrangement)
 >

 well ... let's c ...

 > It might be nicer to use a css file to style the elements for which I
 have specified style attributes of course. I also noticed that a change
 from using {{{.offset2}}} to {{{.span6}}} seemed to give a better layout.
 Anyway, this looks a bit like the following:
 >

 -1 . If activity feed is not available (e.g. dashboard is disabled ) then
 target `div` should cover the whole width (that'd be approximately ...
 `span10` ? ) and this flexibility won't happen in the solution u suggest .
 IMO what should be done is to add both `offset2` and `span` classes (<=
 yes '''span''' without cols number ''';)''' . Could you please try that ?

 btw ... why is it looking better ?

 [...]
 >
 > The disappearing edit and reply buttons are to be removed in #182
 (which, incidentally looks pretty good but probably needs to be applied
 after this) and any changes associated with the date display in #176.
 >

 ok

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/177#comment:22>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message