incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #162: Convert version control user interface to Bootstrap
Date Wed, 17 Oct 2012 05:52:08 GMT
#162: Convert version control user interface to Bootstrap
--------------------------+--------------------------------
  Reporter:  olemis       |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  major        |  Milestone:  Release 3
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  versioncontrol vcs
--------------------------+--------------------------------

Comment (by olemis):

 Today I started conversion to Bootstrap of repository browser file preview
 . Proposed interface looks like shown below

 [[Image(bh_theme_x_78_file_preview.png, 600)]]

 The lines in file contents area have been introduced as a side effect of
 work previously committed for #88 . They should be removed by applying the
 following tiny update

 {{{
 #!diff

 $ hg diff
 diff -r cc1f958d80ae bhtheme/theme.py
 --- a/bhtheme/theme.py  Wed Oct 17 01:17:09 2012 -0500
 +++ b/bhtheme/theme.py  Wed Oct 17 01:37:12 2012 -0500
 @@ -122,6 +122,8 @@
          """Insert default Bootstrap CSS classes if rendering
          legacy templates (i.e. determined by template name prefix).
          """
 +        if filename.startswith('bh_'):
 +            return stream;
          tx = Transformer('body')

          def add_classes(classes):

 }}}

 Isn't it about time to commit this modification ?

 Any other comments | suggestions are welcome .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message