incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #77: Wrong version of bootstrap in dashboard plugins
Date Fri, 15 Jun 2012 10:49:03 GMT
#77: Wrong version of bootstrap in dashboard plugins
------------------------+-------------------------------------
  Reporter:  gjm        |      Owner:  olemis
      Type:  defect     |     Status:  accepted
  Priority:  critical   |  Milestone:  RC1 for initial release
 Component:  dashboard  |    Version:
Resolution:             |   Keywords:
------------------------+-------------------------------------

Comment (by gjm):

 Good point, in that I had forgotten what the radio behaviour was across,
 but I feel we are still subverting the meaning of the {{{.btn-group}}}
 class.

 If we really need to separate those groups we could do something like
 this:

 {{{
 #!xml
   <div class="btn-toolbar">
     <div class="btn-group offset1" data-toggle="buttons-radio">
       <py:with vars="max_idx = len(layout.toolbar) - 1">
       <py:for each="idx, g in enumerate(layout.toolbar)" >
       <py:for each="tb_item in g" >
       <button data-target="#tb-item-${tb_item.id}" data-toggle="tab"
           disabled="${tb_item.widget is None and 'true' or None}"
           class="btn ${tb_item.widget is None and 'disabled' or None}
 ${tb_item.active and 'active' or None}">
         ${tb_item.caption}
       </button>
       </py:for>
       <py:if test="idx != max_idx">
         <button disabled="true" class="btn disabled invisible">
         </button>
       </py:if>
       </py:for>
       </py:with>
     </div>
   </div>
 }}}

 Perhaps not a perfect reproduction of course.

 Finally, this conversation seems a little useless because if you look at
 the [https://svn.apache.org/repos/asf/incubator/bloodhound/trunk/doc/html-
 templates/product.html product template] (or the
 [https://svn.apache.org/repos/asf/incubator/bloodhound/trunk/doc/html-
 templates/dashboard.html dashboard template] if you prefer) I do not
 believe that we are working with radio buttons in that way any more.

 There is nothing stopping you from raising the issue with bootstrap of
 course.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/77#comment:13>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message