incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #93: Converting dashboard views to new template
Date Tue, 19 Jun 2012 10:33:12 GMT
#93: Converting dashboard views to new template
--------------------------+----------------------
  Reporter:  gjm          |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  major        |  Milestone:
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+----------------------

Comment (by gjm):

 Replying to [comment:23 olemis]:
 > Replying to [comment:21 gjm]:
 > > As a quick hack, I have just been trying the following to modify the
 links provided by the {{{TicketFieldValuesWidget}}} for lists of
 milestones so that they go direct to the relevant page instead of the
 query.
 > >
 >
 > Though I think it will be better this way ...
 >
 [snip]
 > You know , something like that . The idea is avoid calling `item_link`
 inside `dash_item_link` . The `if` statement and associated check should
 also be redundant . Hence that way it should be more efficient . Further
 enhancements still possible ''';)'''

 Possibly, although one of the {{{item_link}}} calls was for the empty
 {{{item[0]}}} and so I was providing the query link for that. Of course,
 that might be a surprise to be using a different view. The redirect to the
 roadmap in the case of {{{path/to/env/milestone/}}} is not particularly
 helpful here. It feels like we should have some kind of milestone display
 for tickets that are not in any milestone though. Perhaps we can provide
 such views on {{{path/to/env/dashboard/milestone/}}} somehow.

 Also, it might be worth providing a dictionary with the dashboard links so
 that we do not need to guarantee that the links are always of the form
 {{{path/to/env/fieldnm/item[0]}}} as the above suggests. We could use
 something like:
 {{{
 #!python
 DASH_ITEM_HREF_MAP = {'milestone': ('dashboard','milestone',)}
 }}}

 which could be translated to a path with:
 {{{
 #!python
 def dash_item_link(item):
     args = self.DASH_ITEM_HREF_MAP[fieldnm] + (item[0],)
     return req.href(*args)
 }}}

 By the way, is there a particular reason for the numeric keys in the
 {{{DASHBOARD_SCHEMA['widgets']}}} dictionary? I'm tempted to change those
 to descriptive names so that I can specify the set of widgets as
 {{{
 #!python
 ['my tickets', 'active tickets', 'milestones', 'components']
 }}}

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/93#comment:24>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message