incubator-bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject [Apache Bloodhound] #121: Remove Back to Roadmap link from Milestone pages when Roadmap is disabled
Date Fri, 29 Jun 2012 17:04:24 GMT
#121: Remove Back to Roadmap link from Milestone pages when Roadmap is disabled
-----------------------+-------------------------------------
 Reporter:  gjm        |      Owner:  nobody
     Type:  defect     |     Status:  new
 Priority:  major      |  Milestone:  RC1 for initial release
Component:  trac core  |    Version:
 Keywords:             |
-----------------------+-------------------------------------
 If the Roadmap module is not activated, there is no reason for a Milestone
 to show a link back to the missing Roadmap page.

 Is this due to anything we have done?

 Something like this would fix it:
 {{{
 #!diff
 Index: trac/ticket/roadmap.py
 ===================================================================
 --- trac/ticket/roadmap.py      (revision 1353999)
 +++ trac/ticket/roadmap.py      (working copy)
 @@ -886,8 +886,9 @@
              if idx < len(milestones) - 1:
                  add_milestone_link('next', milestones[idx + 1])
                  add_milestone_link('last', milestones[-1])
 +        roadmap_back = self.env[RoadmapModule] and _('Back to Roadmap')
 or None
          prevnext_nav(req, _('Previous Milestone'), _('Next Milestone'),
 -                     _('Back to Roadmap'))
 +                         roadmap_back)

          return 'milestone_view.html', data, None

 }}}

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/121>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message