Mailing-List: contact bloodhound-commits-help@incubator.apache.org;
 run by ezmlm
Precedence: bulk
Reply-To: bloodhound-dev@incubator.apache.org
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: "Apache Bloodhound" <bloodhound-dev@incubator.apache.org>
Cc: bloodhound-commits@incubator.apache.org
Auto-Submitted: auto-generated
Date: Wed, 04 Apr 2012 17:38:33 -0000
Reply-To: bloodhound-dev@incubator.apache.org
Subject: Re: [Apache Bloodhound] #27: Request that the ThemeEngine alters
 their implementation to work for Trac 0.13 (was: Request that the
 !ThemeEngine alters their implementation to work for Trac 0.13)
Message-ID: <067.4839de9f555619be7bc2c5589f8e2ee6@incubator.apache.org>
References: <052.44af7bbc4ac9678c768ac8dfa3143525@incubator.apache.org>
In-Reply-To: <052.44af7bbc4ac9678c768ac8dfa3143525@incubator.apache.org>

#27: Request that the ThemeEngine alters their implementation to work for Trac
0.13
----------------------+-------------------------
  Reporter:  gjm      |      Owner:  gjm
      Type:  task     |     Status:  new
  Priority:  major    |  Milestone:  Unscheduled
 Component:  plugins  |    Version:
Resolution:           |   Keywords:
----------------------+-------------------------

Old description:

> Changes to Trac's component model stopped the [http://trac-
> hacks.org/wiki/ThemeEnginePlugin ThemeEnginePlugin] working due to the
> recursion error discussed in #22.
>
> Although #22 provides Bloodhound's branch of Trac with a way of dealing
> with this, it would be better for the !ThemeEngine to find a way of
> dealing with the recursion and for us to catch recursion errors to report
> the error more gracefully.
>
> If we can convince the !ThemeEngine to make this change, please raise a
> new ticket for handling recursion errors.

New description:

 Changes to Trac's component model stopped the [http://trac-
 hacks.org/wiki/ThemeEnginePlugin ThemeEnginePlugin] working due to the
 recursion error discussed in #22.

 Although #22 provides Bloodhound's branch of Trac with a way of dealing
 with this, it would be better for the !ThemeEngine to find a way of
 dealing with the recursion and for us to catch recursion errors to report
 the error more gracefully.

 If we can convince the !ThemeEngine to make this change, please raise a
 new ticket for handling all component initialisation errors.

--

Comment (by gjm):

 Updated summary as Ethan Jucovy pointed out that it is not just recursion
 errors that can error. The resulting ticket should make sure that we
 handle all initialisation errors gracefully:

  > Surviving the exception would be nice; even just catching the exception
 and re-raising it wrapped in some kind of
 !PluginInitializationException(plugin_name, exc) would probably be better
 than the current behavior.
 (from [http://mail-archives.apache.org/mod_mbox/incubator-bloodhound-
 dev/201204.mbox/%3CCAMmgw9k470qZ3=VQDryDoz=ShC1MMx=0sKgBi83yUPgyiww8KA@mail.gmail.com%3E
 Ethan's reply])

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/27#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker