incubator-bigtop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roman Shaposhnik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BIGTOP-716) standardize on bash as a shell of choice
Date Wed, 26 Sep 2012 21:33:08 GMT

    [ https://issues.apache.org/jira/browse/BIGTOP-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464186#comment-13464186
] 

Roman Shaposhnik commented on BIGTOP-716:
-----------------------------------------

{noformat}
Here's what a simple git grep '#!.*[^a]sh' uncovered:
bigtop-packages/src/common/bigtop-jsvc/do-component-build:#!/bin/sh
bigtop-packages/src/common/bigtop-tomcat/do-component-build:#!/bin/sh
bigtop-packages/src/common/datafu/do-component-build:#!/bin/sh
bigtop-packages/src/common/datafu/install_datafu.sh:#!/bin/sh
bigtop-packages/src/common/flume/do-component-build:#!/bin/sh
bigtop-packages/src/common/flume/install_flume.sh:#!/bin/sh
bigtop-packages/src/common/giraph/do-component-build:#!/bin/sh
bigtop-packages/src/common/giraph/install_giraph.sh:#!/bin/sh
bigtop-packages/src/common/giraph/install_giraph.sh:#!/bin/sh
bigtop-packages/src/common/hadoop/do-component-build:#!/bin/sh
bigtop-packages/src/common/hadoop/install_hadoop.sh:#!/bin/sh
bigtop-packages/src/common/hbase/do-component-build:#!/bin/sh
bigtop-packages/src/common/hbase/install_hbase.sh:#!/bin/sh
bigtop-packages/src/common/hbase/install_hbase.sh:#!/bin/sh
bigtop-packages/src/common/hive/do-component-build:#!/bin/sh
bigtop-packages/src/common/hive/install_hive.sh:#!/bin/sh
bigtop-packages/src/common/hive/install_hive.sh:#!/bin/sh
bigtop-packages/src/common/hue/do-component-build:#!/bin/sh
bigtop-packages/src/common/hue/install_hue.sh:#!/bin/sh
bigtop-packages/src/common/mahout/do-component-build:#!/bin/sh
bigtop-packages/src/common/mahout/install_mahout.sh:#!/bin/sh
bigtop-packages/src/common/mahout/install_mahout.sh:#!/bin/sh
bigtop-packages/src/common/oozie/install_oozie.sh:#!/bin/sh
bigtop-packages/src/common/oozie/install_oozie.sh:#!/bin/sh
bigtop-packages/src/common/oozie/oozie.init:#! /bin/sh
bigtop-packages/src/common/pig/do-component-build:#!/bin/sh
bigtop-packages/src/common/pig/install_pig.sh:#!/bin/sh
bigtop-packages/src/common/pig/install_pig.sh:#!/bin/sh
bigtop-packages/src/common/sqoop/do-component-build:#!/bin/sh
bigtop-packages/src/common/sqoop/install_sqoop.sh:#!/bin/sh
bigtop-packages/src/common/sqoop/install_sqoop.sh:#!/bin/sh
bigtop-packages/src/common/whirr/do-component-build:#!/bin/sh
bigtop-packages/src/common/whirr/install_whirr.sh:#!/bin/sh
bigtop-packages/src/common/zookeeper/do-component-build:#!/bin/sh
bigtop-packages/src/common/zookeeper/install_zookeeper.sh:#!/bin/sh
bigtop-packages/src/common/zookeeper/install_zookeeper.sh:echo '#!/bin/bash' > $BUILD_DIR/bin/zkServer-initialize.sh
bigtop-packages/src/common/zookeeper/install_zookeeper.sh:#!/bin/sh
bigtop-packages/src/common/zookeeper/install_zookeeper.sh:#!/bin/sh
bigtop-packages/src/deb/flume/flume-node.postinst:#!/bin/sh
bigtop-packages/src/deb/flume/flume.postinst:#!/bin/sh
bigtop-packages/src/deb/flume/flume.preinst:#!/bin/sh
bigtop-packages/src/deb/flume/flume.prerm:#!/bin/sh
bigtop-packages/src/deb/giraph/giraph.postinst:#!/bin/sh
bigtop-packages/src/deb/giraph/giraph.prerm:#!/bin/sh
bigtop-packages/src/deb/hadoop/append_licenses.sh:#!/bin/sh
bigtop-packages/src/deb/hadoop/hadoop-conf-pseudo.postinst:#!/bin/sh
bigtop-packages/src/deb/hadoop/hadoop-conf-pseudo.prerm:#!/bin/sh
bigtop-packages/src/deb/hadoop/hadoop-hdfs.postinst:#!/bin/sh
bigtop-packages/src/deb/hadoop/hadoop-hdfs.preinst:#!/bin/sh
bigtop-packages/src/deb/hadoop/hadoop-httpfs.postinst:#!/bin/sh
bigtop-packages/src/deb/hadoop/hadoop-httpfs.preinst:#!/bin/sh
bigtop-packages/src/deb/hadoop/hadoop-httpfs.prerm:#!/bin/sh
bigtop-packages/src/deb/hadoop/hadoop-mapreduce.postinst:#!/bin/sh
bigtop-packages/src/deb/hadoop/hadoop-mapreduce.preinst:#!/bin/sh
bigtop-packages/src/deb/hadoop/hadoop-yarn.postinst:#!/bin/sh
bigtop-packages/src/deb/hadoop/hadoop-yarn.preinst:#!/bin/sh
bigtop-packages/src/deb/hadoop/hadoop.daemon.postinst.tpl:#!/bin/sh
bigtop-packages/src/deb/hadoop/hadoop.postinst:#!/bin/sh
bigtop-packages/src/deb/hadoop/hadoop.preinst:#!/bin/sh
bigtop-packages/src/deb/hadoop/hadoop.prerm:#!/bin/sh
bigtop-packages/src/deb/hbase/hbase.postinst:#!/bin/sh
bigtop-packages/src/deb/hbase/hbase.preinst:#!/bin/sh
bigtop-packages/src/deb/hbase/hbase.prerm:#!/bin/sh
bigtop-packages/src/deb/hbase/install_init_scripts.sh:#!/bin/sh
bigtop-packages/src/deb/hbase/service-postinst.tpl:#!/bin/sh
bigtop-packages/src/deb/hbase/service-postrm.tpl:#!/bin/sh
bigtop-packages/src/deb/hive/hive.postinst:#!/bin/sh
bigtop-packages/src/deb/hive/hive.preinst:#!/bin/sh
bigtop-packages/src/deb/hive/hive.prerm:#!/bin/sh
bigtop-packages/src/deb/hive/install_init_scripts.sh:#!/bin/sh
bigtop-packages/src/deb/mahout/mahout.postinst:#!/bin/sh
bigtop-packages/src/deb/mahout/mahout.prerm:#!/bin/sh
bigtop-packages/src/deb/oozie/oozie.postinst:#!/bin/sh
bigtop-packages/src/deb/oozie/oozie.postrm:#!/bin/sh
bigtop-packages/src/deb/oozie/oozie.preinst:#!/bin/sh
bigtop-packages/src/deb/oozie/oozie.prerm:#!/bin/sh
bigtop-packages/src/deb/pig/pig.postinst:#!/bin/sh
bigtop-packages/src/deb/pig/pig.preinst:#!/bin/sh
bigtop-packages/src/deb/pig/pig.prerm:#!/bin/sh
bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst:#!/bin/sh
bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst:#!/bin/sh
bigtop-packages/src/deb/sqoop/sqoop.postinst:#!/bin/sh
bigtop-packages/src/deb/sqoop/sqoop.prerm:#!/bin/sh
bigtop-packages/src/deb/zookeeper/zookeeper.postinst:#!/bin/sh
bigtop-packages/src/deb/zookeeper/zookeeper.preinst:#!/bin/sh
bigtop-packages/src/deb/zookeeper/zookeeper.prerm:#!/bin/sh
bigtop-tests/test-artifacts/hive/src/main/resources/seed_data_files/ml-data/mku.sh:#!/bin/sh
{noformat}

Should we do a blanket search-n-replace? And follow up with updating package dependencies
as well?
                
> standardize on bash as a shell of choice
> ----------------------------------------
>
>                 Key: BIGTOP-716
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-716
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 0.4.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>            Priority: Minor
>             Fix For: 0.5.0
>
>
> 90% of development and testing of our scripts happens with bash, however, if we don't
enforce {noformat}#!/bin/bash{noformat} and just specify {noformat}#!/bin/sh{noformat} instead
on some of the systems we may end up running against #!/bin/dash and other bash alternatives.
This could lead to subtle problems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message