incubator-bigtop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bruno Mahé (JIRA) <>
Subject [jira] [Commented] (BIGTOP-612) Add Crunch to Bigtop
Date Sat, 22 Sep 2012 03:54:08 GMT


Bruno Mahé commented on BIGTOP-612:

Took a look at that patch and here are my comments:
* {noformat}+mv $BUILD_DIR/crunch-examples/target/apache-crunch-*-job.jar $PREFIX/$LIB_DIR/crunch-examples-job.jar
+for subproject in crunch-hbase crunch-scrunch crunch-examples crunch ; do
+  cp $BUILD_DIR/$subproject/target/apache-crunch*.jar $PREFIX/$LIB_DIR/$subproject.jar
=> Shouldn't the _crunch-examples_ from the for loop be removed since it is already taken
care of the line just before?

* crunch-hbase should probably be in its own subpackage (depending on hbase client jar)

* {noformat}+Maintainer: Bigtop <>{noformat}
=> Should be _Apache Bigtop_

* {noformat}bigtop-packages/src/deb/crunch/copyright{noformat}
 => It's copy/pasted from datafu and should be redone completely

* {noformat}+#CRUNCH_SITE={noformat}
 => to be removed. Remove also the other commented lines. We have source control for that

Other than that, it looks pretty clean. I can't wait to be able to +1 it!
> Add Crunch to Bigtop
> --------------------
>                 Key: BIGTOP-612
>                 URL:
>             Project: Bigtop
>          Issue Type: Task
>          Components: General
>            Reporter: Josh Wills
>            Assignee: Roman Shaposhnik
>             Fix For: 0.5.0
>         Attachments: BIGTOP-612.patch.txt
> Crunch is a Java library for creating data pipelines on Hadoop that recently entered
the Apache Incubator.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message